bugMyPaint - Bugs: bug #18617, brushes should remember the last...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #18617: brushes should remember the last size

Submitted by:  bebin <bebin>
Submitted on:  Thu 08 Sep 2011 05:32:57 AM UTC  
Votes:  100  
 
Severity: 1 - WishPriority: 5 - Normal
Status: WishPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: Planned Release: None
Operating System: 

(Jump to the original submission Jump to the original submission)

Fri 28 Oct 2011 06:00:05 PM UTC, comment #12:

After reading all comments I opt for the "brush state is persistent, but you can discard your changes (such as size) / go back to the original".
Martin: do brushes have version information? If so, customized brushes could simply increment the minor part, whereas mypaint/author changes/updates increment the major value.

Till Hartmann <tillux>
Project Member
Fri 30 Sep 2011 11:40:59 AM UTC, comment #11:

Another issue with the solution above: if you import a new brush (overwriting the previous one), you would end up using the old version until you remember to reset.

This could be solved by checking the timestamp of the original brush (or similar). Simply discard the temporary settings if the timestamp has changed.

Martin Renold <martinxyz>
Project Administrator
Fri 30 Sep 2011 11:39:36 AM UTC, comment #10:

+1 for the autosave of the brush radius and other settings then , and usage of the 'reset all' button if a beginner want to go back to the original setting after hacking too much the brush.

Btw, the button label 'Reset all' is confusing for me. I never touched it, because I thought it would reset all brush. Thanks a lot, it reset only active brush. I propose 'restore to default' or something that sound less dangerous :D

I posted this in a separate bug report here : https://gna.org/bugs/?18762

David REVOY <deevad>
Project Member
Fri 30 Sep 2011 11:34:53 AM UTC, comment #9:

Another way to achieve the things you said would be a "lock" check box on toolbar, and each brush should have a "lock" flag.

When you check it, the currently selected brush gets "locked" and will remember settings. As soon as you un-check it, the brush will work just like it does now. Also the lock/unlock flag's default value (globally) could be set from options.

Mihai Cozma <meeshoo>
Fri 30 Sep 2011 11:23:48 AM UTC, comment #8:

Looks like I missinterpreted the purpose of the original request. Let's focus on a single problem per bugreport: "The brush does not remember size changes". Please use a different bugreport to discuss "cursor does not match stroke width".

I never had this problem myself because I usually stick to a single brush. We already do remember all brush settings together with each tool: if you restart mypaint all your modifications are preserved.

I think it is very clumsy if you have to press a "save" button every time for this. Even if the button is on the toolbar, some people will just not get it or not bother. And I think that if we remember any changes, they should be persistent. It is very silly if you have to re-do them after every start of MyPaint.

I think the most consistent thing to do is to remember all brush settings automatically in the same way that we already remember them per device. When you select the current brush (again), the real settings are restored. It already works this way with the tool settings.

The only disadvantage of this is that it will get confusing when you start to create a new brush, or just explore the brush settings. The next time you select the original brush, you will have all your experimental settings restored.

However, thanks to Andrew, we already have a GUI to show whether the brush has been modified or not, including a "reset all" button! So maybe it will not be too confusing. In addition, we could reset all temporary settings of the original brush, as soon as you save it with a new name.

Martin Renold <martinxyz>
Project Administrator
Fri 30 Sep 2011 10:22:08 AM UTC, comment #7:

Good point David.

I was not necessary thinking of saving the preset completely and for good.I was thinking more like an "in memory state" that is never saved to disk (unless you save it manually as a preset as you said) but it is kept there between brush switches and each time you select a brush, the state is applied over it. It's like a "remember my old setting for a bit until I get in and out another brush".

Also, the default behavior of this (weather it should be an auto save or not) maybe could be set in MyPaint options, so each artist can decide if it wants it one way or another.

Since I'm a software developer by trade (although not very familiar with python, just more C/C++/C# stuff, Windows not Linux) with drawing as a hobby, I might look into this if none of the developers here picks it up and exemplify what I mean by a patch.

Mihai Cozma <meeshoo>
Fri 30 Sep 2011 10:12:57 AM UTC, comment #6:

I understand your POV Mihai, and here I'm also against uniformisation of brush radius and zooming. I zoom not a lot , btw.

I had very often the same issue ; working at different resolutions for various project lead me to adjust constantly the preset I use at the start of a new painting ( mainly size / opacity ... more rarely pressure curves ).

So, I became used to do Ctrl+B , then in the brush setting, press the 'save' button to 'bake' the preset. Then close the brush setting.

With the new GUI toolbar , there is now - Thanks to Andrew - a notification when the brush settings get changed. I suggested by the past to add in the dropdown panel a 'save preset' button.

I think a faster access to this save option can be a wiser solution to solve your and mine little problem . Because saving or overwriting a preset should be , imo, a user action not a autosave.

Just my point of view.

About the radius visual feedback ( brush outline ) of huge sized brush issue where the outliner is limited to a fixed radius, yes that's another problem, I agree on it.

David REVOY <deevad>
Project Member
Fri 30 Sep 2011 08:33:18 AM UTC, comment #5:

I think what we need is a brush "state". Whenever you pickup a brush, it should remember its last state in terms of every possible settings excluding color. If the user wants the default settings (the one that gets loaded now every time you switch back to a brush), there should be a shortcut to do so. I think most of my dead time I spend while painting is re sizing brushes when I switch back to them.

And yes, there should be a way to determine approximately how big a stroke really is, as the circle doesn't do that and it's frustrating.

Typical scenario:
I pickup the Airbrush tool (from Ramon's set), give it a stroke and notice that its way bigger than the circle shows (second problem I've mentioned).

Then after I re-size it to what I want, I do some painting with it and notice that I need to correct some small detail somewhere. So I pick up another brush, correct the detail, then click on Airbrush again. Now it is as big as it was the first time, so I have to resize it again. Quite painful.

So keeping each brush's state until an explicit reset to default action is done by the user is the way to go in my opinion.

Mihai Cozma <meeshoo>
Fri 30 Sep 2011 08:32:07 AM UTC, comment #4:

I think what we need is a brush "state". Whenever you pickup a brush, it should remember its last state in terms of every possible settings excluding color. If the user wants the default settings (the one that gets loaded now every time you switch back to a brush), there should be a shortcut to do so. I think most of my dead time I spend while painting is re sizing brushes when I switch back to them.

And yes, there should be a way to determine approximately how big a stroke really is, as the circle doesn't do that and it's frustrating.

Typical scenario:
I pickup the Airbrush tool (from Ramon's set), give it a stroke and notice that its way bigger than the circle shows (second problem I've mentioned).

Then after I re-size it to what I want, I do some painting with it and notice that I need to correct some small detail somewhere. So I pick up another brush, correct the detail, then click on Airbrush again. Now it is as big as it was the first time, so I have to resize it again. Quite painful.

So keeping each brush's state until an explicit reset to default action is done by the user is the way to go in my opinion.

Mihai Cozma <meeshoo>
Tue 13 Sep 2011 01:05:40 PM UTC, comment #3:

here is what i think when we do a art we need the size of the brush chosen by the artist right now when we switch the brush the radius changes and goes back to its default size each time we change the brush we have to change back to the radius we need. The opacity and hardness might change depending on the type of brush because it influences the brush qualities but the radius should be chosen by the user

bebin <bebin>
Thu 08 Sep 2011 07:29:11 AM UTC, comment #2:

A "ink" brush and the "bulk fill" brush are supposed to have a different radius. I don't think this is a bug.

However it is a problem that you can't change the overall resolution of all brushes. Because of this, brush creators who tend to work at high resolution will make bigger default radius than brush creators who prefer lower resoultion.

(Didn't we have a bug about this already.)

Martin Renold <martinxyz>
Project Administrator
Thu 08 Sep 2011 07:23:23 AM UTC, comment #1:

Because some brushes are smaller than others.

What we can do, is an option for the brush designer to correct the displayed brush radius for every brush, because sometimes the guess of the radius just completely mismatches the usual stroke size.

For some brushes it's also pretty much impossible to know the radius, because it changes depending on how fast you make the stroke.

Martin Renold <martinxyz>
Project Administrator
Thu 08 Sep 2011 05:32:57 AM UTC, original submission:

It will be nice to have a option to uniformize the brush radius size for all the brush. Currently the radius changes when we change the brush.

bebin <bebin>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jonnor (Updated the item)
  • -unavailable- added by tillux (Posted a comment)
  • -unavailable- added by deevad (Posted a comment)
  • -unavailable- added by meeshoo (Voted in favor of this item)
  • -unavailable- added by meeshoo (Posted a comment)
  • -unavailable- added by bebin
  • -unavailable- added by martinxyz (Posted a comment)
  • -unavailable- added by bebin (Submitted the item)
  • -unavailable- added by bebin
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 100 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 04 Jan 2013 09:08:28 PM UTCjonnorStatusNone=>Wish
    Fri 30 Sep 2011 11:23:48 AM UTCmartinxyzSummaryuniform brush radius=>brushes should remember the last size
    Fri 30 Sep 2011 08:33:18 AM UTCmeeshooCarbon-Copy-=>Added meeshoo
    Tue 13 Sep 2011 01:09:14 PM UTCbebinCarbon-Copy-=>Added deevad
    Tue 13 Sep 2011 01:09:00 PM UTCbebinCarbon-CopyRemoved david revoy=>-
    Tue 13 Sep 2011 01:07:39 PM UTCbebinCarbon-Copy-=>Added david revoy
    Tue 13 Sep 2011 01:07:17 PM UTCbebinCarbon-CopyRemoved david revoy=>-
    Tue 13 Sep 2011 01:05:41 PM UTCbebinCarbon-Copy-=>Added david revoy
    Thu 08 Sep 2011 05:32:57 AM UTCbebinCarbon-Copy-=>Added achadwick
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup