subtitleeditor - Bugs: bug #19610, CPS column too wide, translation... [Gna!]

subtitleeditor - Bugs: bug #19610, CPS column too wide, translation...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Support
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Mailing Lists
Source Code
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
News
- Browse
- Atom Feed
- Submit
- Manage

Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #19610: CPS column too wide, translation column too narrow

Submitted by:	Tomáš Hnyk <sup>
Submitted on:	Tue 03 Apr 2012 07:18:00 PM UTC

Category:	None	Severity:	3 - Normal
Priority:	5 - Normal	Status:	Fixed
Privacy:	Public	Assigned to:	kitone <kitone>
Open/Closed:	Closed

Mon 25 Feb 2013 08:46:41 PM UTC, comment #4: Fixed in trunk. Thanks for the patch.	kitone <kitone>
Mon 25 Feb 2013 08:45:27 PM UTC, SVN revision 830: Fix bug #19610 : CPS column too wide, translation column too narrow. Patch by Tom?\195?\161?\197?\161 Hnyk ^. (Browse SVN revision 830)	kitone <kitone>
Wed 20 Feb 2013 08:42:05 AM UTC, comment #2: I messed up formatting of the patch, this should work. (file #17273)	Tomáš Hnyk <sup>
Sun 17 Feb 2013 03:59:27 PM UTC, comment #1: I am attaching a patch that corrects this. It does two things: 1) It sets text and translation columns to expand, which means that they will divide between them all the available space that is not needed by other columns. Previously, this space went to CPS which did not need is as it normaly is not mor than 4 characters wide. This fixes the original issue. 2) It also sets CellRendererText for translation and text columns to ellipsize the end of the subtitles so that the text is truncated when it is longer then the clumns width. Previously, it would increase the size of the column to match the length of the line. This would result in a horizontal scrollbar to reach the columns right off the text of translation fileds, which would have been shifted off the screen. I think that this is much more user friendly (and the subtitles should never be more then 30-40 characters wide anyway). I hope the patch is in the correct format, this is a second time I am sending a patch in my life:-). (file #17239)	Tomáš Hnyk <sup>
Tue 03 Apr 2012 07:18:00 PM UTC, original submission: When translation and CPS column is enabled, CPS column is too wide be default and translation is too narrow (see screenshots). However, CPS is unlikely to be more then 4 characters wide, unlike translation. I propose this is handled somehow (so that translation and text column take as much space as possible, not CPS column that does not need the time).	Tomáš Hnyk <sup>

Attached Files

file #17273: truncate_text_and_translation_and_expand_them.patch added by sup (980B - application/octet-stream - Hopefully a properly formatted patch.)

file #17239: truncate_text_and_translation_and_expand_them.patch added by sup (1kB - application/octet-stream)

file #15509: How it looks like by default.png added by sup (179kB - image/png)

file #15508: How it should look like.png added by sup (345kB - image/png)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by kitone (Posted a comment)

-unavailable- added by sup (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 7 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Mon 25 Feb 2013 08:46:41 PM UTC	kitone	Status	None	Fixed
		Assigned to	None	kitone
		Open/Closed	Open	Closed
Wed 20 Feb 2013 08:42:05 AM UTC	sup	Attached File	-	Added truncate_text_and_translation_and_expand_them.patch, #17273
Sun 17 Feb 2013 03:59:27 PM UTC	sup	Attached File	-	Added truncate_text_and_translation_and_expand_them.patch, #17239
Tue 03 Apr 2012 07:18:01 PM UTC	sup	Attached File	-	Added How it looks like by default.png, #15509
Tue 03 Apr 2012 07:18:00 PM UTC	sup	Attached File	-	Added How it should look like.png, #15508

Show feedback again