bugFreeciv - Bugs: bug #19932, Attempting to set a goto path with...

 
 
Show feedback again

bug #19932: Attempting to set a goto path with the end tile also being a waypoint does nothing

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Thu 12 Jul 2012 10:42:54 PM UTC  
 
Category: clientSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: trunk r21520Operating System: GNU/Linux
Planned Release: 2.3.5,2.4.2,2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 13 Jan 2014 09:21:13 PM UTC, SVN revision 24111:

Test whether the paths are NULL to determine if the client goto order is valid
or not. Then attempting to set a goto path with end tile also being a waypoint
works as expected.

Reported by Jacob Nevins

See gna bug #19932

(Browse SVN revision 24111)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 13 Jan 2014 09:21:09 PM UTC, SVN revision 24110:

Test whether the paths are NULL to determine if the client goto order is valid
or not. Then attempting to set a goto path with end tile also being a waypoint
works as expected.

Reported by Jacob Nevins

See gna bug #19932

(Browse SVN revision 24110)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 13 Jan 2014 09:21:05 PM UTC, SVN revision 24109:

Test whether the paths are NULL to determine if the client goto order is valid
or not. Then attempting to set a goto path with end tile also being a waypoint
works as expected.

Reported by Jacob Nevins

See gna bug #19932

(Browse SVN revision 24109)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 13 Jan 2014 09:21:02 PM UTC, SVN revision 24108:

Test whether the paths are NULL to determine if the client goto order is valid
or not. Then attempting to set a goto path with end tile also being a waypoint
works as expected.

Reported by Jacob Nevins

See gna bug #19932

(Browse SVN revision 24108)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 08 Jan 2014 10:40:24 AM UTC, comment #4:

> end==start looks like it might be a special internal signal
> from pathfinding. If so, we should presumably filter out "real"
> end==start segments before they get this far.


Actually, this signal is not pathfinding related, but a logic only used in "client/goto.c". The pathfinding signal is that the returned path are NULL. The patch I am attaching use this logic.

(file #19709)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 05 Aug 2012 08:38:35 PM UTC, comment #3:

Bit more info (incomplete analysis):

  • the abort happens in send_goto_route():
  • end==start looks like it might be a special internal signal from pathfinding. If so, we should presumably filter out "real" end==start segments before they get this far.
Jacob Nevins <jtn>
Project Administrator
Fri 13 Jul 2012 05:43:27 PM UTC, comment #2:

Confirmed, and also tested that other zero-length parts work: you can make initial tile waypoint first waypoint, and you can make same tile waypoint twice, and everything works as long as last waypoint is not same tile as final destination.

Marko Lindqvist <cazfi>
Project Administrator
Thu 12 Jul 2012 10:52:22 PM UTC, comment #1:

Confirmed on S2_4 and S2_3 too.

Jacob Nevins <jtn>
Project Administrator
Thu 12 Jul 2012 10:42:54 PM UTC, original submission:

Noticed in passing on trunk.

  • Start a goto path for a unit (G).
  • Move to a tile and set a waypoint (G).
  • Immediately left-click on the same tile to finish the path.

Expected: unit starts goto.
Actual: nothing happens, goto path lost.

Haven't checked other branches yet.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 13 Jan 2014 09:21:53 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 08 Jan 2014 10:40:24 AM UTCpepetoAttached File-=>Added 0001-Fix-for-bug-19932.patch, #19709
      StatusConfirmed=>Ready For Test
      Planned Release=>2.3.5,2.4.2,2.5.0,2.6.0
    Wed 22 May 2013 11:57:31 AM UTCpepetoAssigned toNone=>pepeto
    Thu 12 Jul 2012 10:52:22 PM UTCjtnStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup