bugFreeciv - Bugs: bug #20000, Initial state of chatline toolbar...

 
 
Show feedback again

bug #20000: Initial state of chatline toolbar is wrong

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 29 Jul 2012 10:55:24 AM UTC  
 
Category: client-gtk-3.0Severity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4 r21637Operating System: GNU/Linux
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Dec 2012 12:46:16 AM UTC, SVN revision 22081:

Keep gtk3-client chatline toolbar hidden initially as it should be to match
state of the 'Chat tools' button.

Reported by Jacob Nevins

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o

See gna bug #20000

(Browse SVN revision 22081)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 15 Dec 2012 12:46:09 AM UTC, SVN revision 22080:

Keep gtk3-client chatline toolbar hidden initially as it should be to match
state of the 'Chat tools' button.

Reported by Jacob Nevins

Patch by Rafa?\197?\130 Mu?\197?\188y?\197?\130o

See gna bug #20000

(Browse SVN revision 22080)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 12 Dec 2012 11:01:27 AM UTC, comment #2:

- Updated against current svn / only relevant part

(file #16840)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 29 Jul 2012 03:48:39 PM UTC, comment #1:

I suspect the only mistake could be relying on some side effect of running in expose-event.

Attaching something that seems to fix the problem.

The second block is just a minor gtk3 cleanup.

(file #16233)

Rafał Mużyło <galtgendo>
Sun 29 Jul 2012 10:55:24 AM UTC, original submission:

The "Chat tools" button starts in the deactivated state (popped out), but the toolbar (bold, strikethrough, etc) is nevertheless shown. (In the Gtk2 client it's initially hidden.)
The first time the tools button is pressed, nothing happens other than that the button goes in.
After that it behaves as designed.

I haven't spotted an obvious mistake in chatline.c. I'm not sure what sets the initial hidden state in gtk2 -- probably the set_toolbar_visibility() callback connected to "expose-event". In gtk3 this is connected to "map"; perhaps that makes things happen in the wrong order?

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16840:  ChatToolsInitState.patch added by cazfi (622B - text/x-diff)
file #16233:  fix-chat-toolbar-visibility.patch added by galtgendo (1kB - text/x-patch - fix initial chat toolbar visibility)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by galtgendo (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Dec 2012 12:46:42 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 12 Dec 2012 11:01:27 AM UTCcazfiAttached File-=>Added ChatToolsInitState.patch, #16840
    Mon 10 Dec 2012 04:37:16 PM UTCcazfiStatusNone=>Ready For Test
    Sun 29 Jul 2012 03:48:39 PM UTCgaltgendoAttached File-=>Added fix-chat-toolbar-visibility.patch, #16233
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup