bugFreeciv - Bugs: bug #20055, trunk, trident: assertion...

 
 
Show feedback again

bug #20055: trunk, trident: assertion 't->sprites.roads[index].even[1 << i] != NULL' failed.

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 11 Aug 2012 08:46:01 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: trunk r21783Operating System: GNU/Linux
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Jan 2013 06:43:09 PM UTC, SVN revision 22160:

Make sure that iteration does not go over array bounds.

Reported by freim (Hogne)

See gna bug #20055

(Browse SVN revision 22160)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Jan 2013 06:43:04 PM UTC, SVN revision 22159:

Make sure that iteration does not go over array bounds.

Reported by freim (Hogne)

See gna bug #20055

(Browse SVN revision 22159)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 19 Jan 2013 06:42:58 PM UTC, SVN revision 22158:

Make sure that iteration does not go over array bounds.

Reported by freim (Hogne)

See gna bug #20055

(Browse SVN revision 22158)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 17 Jan 2013 02:47:43 PM UTC, comment #2:

Fix

(file #16960, file #16961)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 11 Aug 2012 10:06:47 PM UTC, comment #1:

The change that has triggered this is in how representative icon of road type (which was one of the special types in earlier versions) for editor menu is constructed. Earlier versions iterated over sprites until they found legal one. 2.5 iterates over them all, and add all legal ones. This iteration goes far over legal bounds (legal: 2^(dirs / 2), used: 2^dirs). The bug is in principle in old code too, it would go over legal bounds if no legal sprite is found, causing iteration to abort, before.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 11 Aug 2012 08:46:01 PM UTC, original submission:

Reported by freim (Hogne) on IRC, confirmed by me:

Starting trunk (r21783) client with trident tileset gives assertion errors:

Backtrace with -F (from me):

(Discovered because he was running into similar assertions with his own new tileset he's developing.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16960:  EvenRoads.patch added by cazfi (621B - text/x-diff)
file #16961:  EvenRoads-S2_4.patch added by cazfi (946B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  • -unavailable- added by jtn
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Jan 2013 06:44:26 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 17 Jan 2013 02:47:43 PM UTCcazfiAttached File-=>Added EvenRoads.patch, #16960
      Attached File-=>Added EvenRoads-S2_4.patch, #16961
      Categoryclient-gtk-2.0=>client
      StatusConfirmed=>Ready For Test
      Planned Release2.5.0=>2.3.4, 2.4.0, 2.5.0
    Sat 11 Aug 2012 08:57:57 PM UTCcazfiAssigned toNone=>cazfi
    Sat 11 Aug 2012 08:46:01 PM UTCjtnCarbon-Copy-=>Added hogne
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup