bugBattle for Wesnoth - Bugs: bug #20106, Campaign difficulty level reset to...

 
 
Show feedback again

bug #20106: Campaign difficulty level reset to Normal when reloading from saved games

Submitted by:  Ignacio R. Morelle <shadowmaster>
Submitted on:  Tue 28 Aug 2012 09:03:58 AM UTC  
 
Category: BugSeverity: 5 - Blocker
Priority: 7 - HighItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Anja K <ayne>Open/Closed: Closed
Release: 1.11.0, trunk r55176Operating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Sep 2012 09:46:23 AM UTC, comment #3:

Fix confirmed.

Ignacio R. Morelle <shadowmaster>
Project Administrator
Tue 04 Sep 2012 04:27:41 PM UTC, comment #2:

I committed a fix, please confirm if everything works as expected. Thanks.

Anja K <ayne>
Project MemberIn charge of this item.
Tue 04 Sep 2012 04:24:13 PM UTC, SVN revision 55242:

Fixed bug #20106

(Browse SVN revision 55242)

Anja K <ayne>
Project MemberIn charge of this item.
Tue 28 Aug 2012 09:03:58 AM UTC, original submission:

When loading single-player campaign saved games, the difficulty information cannot be read from the save (which results in the difficulty description reading as "UNTLB" in the Load Game dialog) and the game falls back to the NORMAL difficulty level.

The real difficulty level does seem to exist in the saved game WML under [snapshot], but it's not taken into consideration.

This trunk (and 1.11.0) regression was introduced by r55053.

Steps to reproduce:

- Start A Tale of Two Brothers on any of the two difficulty levels. Do note that they are internally identified by the EASY and HARD preprocessor symbols, respectively.
- Save at the start of turn 1 of the first scenario, and immediately proceed to reload that save through the Load Game dialog.
- Turn debug mode on with :debug, use :n to advance to the next scenario.
- You will start the next scenario without a turn limit, and if you check the status table you'll notice your enemy starts with zero gold. This is because both these attributes are only defined when EASY or HARD are defined, due to the campaign's design.

A more technical test:

- Edit any scenario from A Tale of Two Brothers to add the following code snippet at the beginning
- Do as the first guide describes, and you'll hit a preprocessor error message upon reloading from a save.

Ignacio R. Morelle <shadowmaster>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ayne (Posted a comment)
  • -unavailable- added by shadowmaster (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Dec 2012 09:36:33 AM UTCivanovicOpen/ClosedOpen=>Closed
    Sat 08 Sep 2012 09:46:23 AM UTCshadowmasterStatusReady For Test=>Fixed
    Tue 04 Sep 2012 04:27:41 PM UTCayneStatusNone=>Ready For Test
    Sat 01 Sep 2012 09:35:41 PM UTCshadowmasterAssigned toNone=>ayne
    Tue 28 Aug 2012 09:06:14 AM UTCshadowmasterSummaryCampaign difficulty level discarded when reloading from saved games=>Campaign difficulty level reset to Normal when reloading from saved games
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup