bugSavane - Bugs: bug #2011, Deletion from group not reflected...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #2011: Deletion from group not reflected in the system if the user is still member of other groups

Submitted by:  Sylvain Beucler <beuc>
Submitted on:  Thu 10 Feb 2005 03:23:57 PM UTC  
 
Category: BackendStatus: Fixed
Severity: 3 - NormalPriority: D - High
Assigned to: Mathieu Roy <yeupou>Open/Closed: Closed
Release: Planned Release: 
Reproducibility: NonePrivacy: Public

Sat 26 Feb 2005 10:44:02 AM UTC, comment #3:

Ok.

(I lowered the severity, it's not like if the bug was frequently encountered and ever had dramatic consequences - but at the same time I raised the priority)

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Thu 10 Feb 2005 04:07:30 PM UTC, comment #2:

I didn't say "not member of any group", I said "a member that is part of 4 groups and then only 3 groups after leaving one of them".
In the latter case, the user will stay in the 4 system groups.

Sylvain Beucler <beuc>
Project Administrator
Thu 10 Feb 2005 03:51:43 PM UTC, comment #1:

I'm not sure to understand exactly the bug. When a user created by Savane is no longer member of any Savane groups, it is removed from the system.
So indeed deletions are taken into account. In the logs at Gna, we sometimes found that users are removed from groups because they left it.

The following bits of code should take care of that:

# Find out users that should be really removed: they are marked as D
# in the database or they are not member of any group but are
# in the database and on the system.
# These users must be in both the database and the system.
my @to_be_removed;
foreach my $user (@well_known) {
# First test: looks for the typical case when someone is no
# longer member of any project: we just list
# Second test: looks for the marked as D users
if (!exists($db_user_group{$user}) || $db_user{$user}->[5] eq 'D') {
# Last test: check if we are not dealing with an account ignored
# (it should not be necessary at this point but it does not cost much)
push(@to_be_removed, $user) unless $etc_password_tobeignored{$user};
}
}

[...]

# Remove users marked as D in the database.
# This is the safest way to remove users quitting savannah.
foreach my $user (@to_be_removed) {
next if $etc_password_tobeignored{$user};

print LOG strftime "[$script] %c ---- delete $user account\n", localtime;
print "DBG delete: $user is marked as D or no longer member of any project\n" if $debug;
DeleteUser($user) unless $debug;

}

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Thu 10 Feb 2005 03:23:57 PM UTC, original submission:

Looks like when a user is deleted from a Savane group, it is not removed from the system group.

AFACS the backend compare sys and db+sys, which means only group inclusions, not deletions, are taken into account.

Sylvain Beucler <beuc>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yeupou (Posted a comment)
  • -unavailable- added by beuc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Mar 2005 10:38:35 AM UTCyeupouStatus102(Error - Not Found)=>Fixed
      Open/ClosedOpen=>Closed
    Wed 02 Mar 2005 10:18:26 AM UTCyeupouAssigned toNone=>yeupou
    Sat 26 Feb 2005 10:44:02 AM UTCyeupouSeverity4 - Important=>3 - Normal
      PriorityA - Later=>D - High
      StatusNone=>102(Error - Not Found)
    Thu 10 Feb 2005 04:36:51 PM UTCyeupouSummaryDeletion from group not reflected in the system=>Deletion from group not reflected in the system if the user is still member of other groups
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup