bugBattle for Wesnoth - Bugs: bug #20290, cannot open list of saved files...

 
 
Show feedback again

bug #20290: cannot open list of saved files (wesnoth crash) following erroneous autosave

Submitted by:  None
Submitted on:  Fri 09 Nov 2012 11:13:24 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Mark de Wever <mordante>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 1.10.4
Operating System: xubuntu precise

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 10 Feb 2013 09:24:59 AM UTC, SVN revision 56269:

Fixed terminating due to a corrupt savegame.

When in the load dialog a corrupt savegame was selected the game would
terminate due to an unhandled exception. If the savegame was the newest
savegame it was no longer possible to open the dialog at all.

(Fixes bug #20290, backported from r56267.)

(Browse SVN revision 56269)

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sun 10 Feb 2013 09:21:19 AM UTC, SVN revision 56267:

Fixed terminating due to a corrupt savegame.

When in the load dialog a corrupt savegame was selected the game would
terminate due to an unhandled exception. If the savegame was the newest
savegame it was no longer possible to open the dialog at all.

(Fixes bug #20290.)

(Browse SVN revision 56267)

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sun 10 Feb 2013 08:34:07 AM UTC, comment #2:

I think it will be hard/impossible to discover how the corrupt savegame came to be, unless the original poster has additional information.

However I'll look at fixing the crash when trying to load the savegame.

Mark de Wever <mordante>
Project MemberIn charge of this item.
Wed 14 Nov 2012 10:00:52 PM UTC, comment #1:

After removing the erroneous save, were you able to continue the game from turn 14? (I tried to load it, but I don't have the right add-ons installed.)

A quick clarification: when the game said "cannot be created", it really meant "cannot be created successfully" -- the file exists, but it appears to be truncated. (It is smaller than the turn 14 save, and my decompressor tells me it is corrupt.) It seems as though BfW choked in the middle of creating the file.

I see three issues here:

1) Something caused BfW to choke mid-save.

2) After choking, the useless incomplete save was not deleted. (Or maybe after choking, the game should have tried an uncompressed save so we can see what is in it?)

3) The incomplete save causes BfW to crash when calling up the "Load Game" dialog (because nothing handles the gzip_error exception).

The latter two are probably easy to address for someone who is familiar with those parts of the code (not me at the moment). The first might be tricky to track down if it cannot be reliably reproduced. (In fact, the first might be more the fault of UMC WML than the game itself, but that remains to be seen.)

J Tyne <jamit>
Project Member
Fri 09 Nov 2012 11:13:24 PM UTC, original submission:

terminal output - http://pastebin.com/x1hk4Bs7

after an 'cannot autosave' notification or smth similar, i quit the current game
from the start window, everytime i click 'load' wesnoth crashes
problem solved by deleting the erroneous, supposedly 'cannot be created' autosave, which in fact exist in the saves directory
this (auto#15) however cannot be opened (attached and also the working #14)

sorry, if it's not a decent report, never wrote smth like this before, searched for help in the @freenode/#wesnoth
and was asked to come here and QUOTE: "go to bugs.wesnoth.org and create a report describing your problem
please attach both saves, the broken and the working one and also paste the terminal output"

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16743:  TLB-1-The_Passing_of_Barus-Auto-Save14.gz added by None (248kB - application/x-gzip - autosaves)
file #16744:  TLB-1-The_Passing_of_Barus-Auto-Save15.gz added by None (180kB - application/x-gzip - autosaves)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mordante (Posted a comment)
  • -unavailable- added by jamit (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:38:25 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 10 Feb 2013 09:25:18 AM UTCmordanteStatusIn Progress=>Fixed
    Sun 10 Feb 2013 08:34:07 AM UTCmordanteStatusNone=>In Progress
      Assigned toNone=>mordante
    Fri 09 Nov 2012 11:13:24 PM UTCNoneAttached File-=>Added TLB-1-The_Passing_of_Barus-Auto-Save14.gz, #16743
      Attached File-=>Added TLB-1-The_Passing_of_Barus-Auto-Save15.gz, #16744
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup