bugMyPaint - Bugs: bug #20311, [Meta] Colour picker picks black...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #20311: [Meta] Colour picker picks black too often (various bugs, workaround needed)

Submitted by:  Andrew Chadwick <achadwick>
Submitted on:  Tue 20 Nov 2012 02:06:10 PM UTC  
 
Severity: 3 - NormalPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: Andrew Chadwick <achadwick>Open/Closed: Closed
Release: git master c807c35c7fPlanned Release: None
Operating System: 

(Jump to the original submission Jump to the original submission)

Fri 04 Jan 2013 09:00:35 PM UTC, comment #7:

This bug has been closed because it is marked ready-for-test and
no further comments have been added in a long while. Since we
have not heard otherwise, we assume that the fixes works as intended.

If there are problems with the implemented functionality, please
file a new issue.

Jon Nordby <jonnor>
Project Administrator
Mon 03 Dec 2012 11:53:47 AM UTC, comment #6:

Not sure if this is fixed for everything, but it's looking promising. I'm crossing my fingers and relying on the intuition that modern systems are more likely to give us images of either stuff in our own address space (Windows, I guess; OSX too?), or from remote resources the app owns... (X11, fancy gpu widget rendering everywhere) via the GTK calls.

The problem with (Debian testing + GNOME + Virtualbox-on-nVidia-G98) from comment #2 has gone away in f38b4b8, which is nice.

It seems to have improved the situation with (Ubuntu 12.10 + Unity + Radeon 5770) too: http://forum.intilinux.com/mypaint-help-and-tips/(ubuntu-12-10)-bug-when-i%27m-using-%27pick-color%27-tool/msg11808/#msg11808

If it still happens with other combinations, it may be necessary to introduce a third level of TiledDrawWidget-aware picker code which can just use the internal rendering routines if the GDK window under the cursor is that of a known TDW. I'm trying to avoid having to do that though.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Sun 02 Dec 2012 08:55:57 AM UTC, comment #5:

PS: did I forget to mention that it's great to finally have a solution for this so often-reported bug? Thanks :-)

Martin Renold <martinxyz>
Project Administrator
Sun 02 Dec 2012 08:53:01 AM UTC, comment #4:

I've never been able to reproduce this bug myself. But testing it on xfce, I think the new behaviour is good.

There is a minor regression: I can't press and hold R to pick from an outside window (allthough it works on MyPaint widgets). I don't think it's a real problem, because most people didn't expect this to work anyway, and the color picker button from the dialog can still do it.

Martin Renold <martinxyz>
Project Administrator
Sun 02 Dec 2012 01:30:15 AM UTC, comment #3:

This might be fixed by the experimental workaround in https://gitorious.org/mypaint/mypaint/commit/f38b4b8a52e7f679853992424b8d5cd985efec9c. I'm not able to reproduce this right now on my system (native Debian testing/Wheezy, under Gnome3 or Xfce4; Virtualbox guest Ubuntu 12.10 under Unity) with Intel video hardware, but it seems plausible .

Please could everyone test? If you're bitten by this bug, hopefully you'll find that picking still doesn't work on non-MyPaint windows, but that it's fixed on MyPaint's own canvases, toolbars and buttons.

Would be interested if you see the colour picker pick pure #ff0000 red anywhere it shouldn't. I've improved the error checking, and I'm using that colour as a flag for when grabbing areas of the screen to a pixbuf before sampling/averaging fails in a detectable way. It won't be enough to fix this everywhere, but it should allow us to distinguish between fail cases.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Wed 28 Nov 2012 05:42:01 PM UTC, comment #2:

Happens slightly differently under fresh out-of-the-box Gnome3 in Debian testing/Wheezy: picking works, but can only sample the nice dark blue and grey background image from the root window, and nothing else, even when the foreground MyPaint window is pointed at during "R" colour pick or ctrl+button1.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Thu 22 Nov 2012 04:45:45 AM UTC, comment #1:

Triaging: mark confirmed.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Tue 20 Nov 2012 02:06:10 PM UTC, original submission:

The colour picker pick black in Windows, on second screens:

In OSX:

And now in Ubuntu 12.10, though possibly just with some hardware combos:

They might well be GTK issues. However to make this less of a pain to users, we should implement a workaround: have the picker work in the old way whereby colours would be picked from the canvas, but have that only happen when the current Gdk window is that of the canvas. At other times, use the current implementation (using gdk.Pixbuf.get_from_drawable() or Gdk.pixbuf_get_from_window()).

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jonnor (Posted a comment)
  • -unavailable- added by martinxyz (Posted a comment)
  • -unavailable- added by achadwick (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 04 Jan 2013 09:00:35 PM UTCjonnorOpen/ClosedOpen=>Closed
    Sun 02 Dec 2012 01:30:15 AM UTCachadwickStatusConfirmed=>Ready For Test
      Assigned toNone=>achadwick
    Thu 22 Nov 2012 04:45:45 AM UTCachadwickStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup