bugBattle for Wesnoth - Bugs: bug #20350, [disallow_end_turn] state is not...

 
 
Show feedback again

bug #20350: [disallow_end_turn] state is not kept correctly across save/reload

Submitted by:  Ignacio R. Morelle <shadowmaster>
Submitted on:  Wed 05 Dec 2012 05:06:56 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Ignacio R. Morelle <shadowmaster>Open/Closed: Closed
Release: 1.10.xOperating System: Maybe any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 05 Dec 2012 05:23:38 AM UTC, SVN revision 55813:

Fix [disallow_end_turn] losing effect on save/reload (bug #20350)

Read can_end_turn from the save's [snapshot], not its parent node.

This fix is already present in trunk, presumably due to the refactoring
of the affected code.

(Browse SVN revision 55813)

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.
Wed 05 Dec 2012 05:06:56 AM UTC, original submission:

The effects of the [disallow_end_turn] WML action are not remembered after save-reloading in Wesnoth 1.10.x, even though can_end_turn is properly set to no under the [snapshot] node in saved games.

Steps to reproduce:
- Insert a [disallow_end_turn] action in a scenario's prestart event and run the scenario.
- Try to end your turn; you will be presented with a message stating you are not allowed to end your turn yet.
- Save and reload.
- Try to end your turn; you will succeed.

This does not appear to affect trunk, possibly as a side effect of ayne's refactoring around the code responsible for retrieving the can_end_turn and other attributes from saved games.

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:27:42 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 09 Dec 2012 01:21:07 PM UTCshadowmasterOpen/ClosedClosed=>Open
    Sun 09 Dec 2012 09:39:42 AM UTCivanovicOpen/ClosedOpen=>Closed
    Wed 05 Dec 2012 05:52:38 AM UTCshadowmasterStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup