bugBattle for Wesnoth - Bugs: bug #20351, [disallow_end_turn] state persists...

 
 
Show feedback again

bug #20351: [disallow_end_turn] state persists when advancing scenarios

Submitted by:  Ignacio R. Morelle <shadowmaster>
Submitted on:  Wed 05 Dec 2012 05:15:34 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Ignacio R. Morelle <shadowmaster>Open/Closed: Closed
Release: 1.10.xOperating System: Maybe any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 25 Dec 2012 10:37:32 PM UTC, SVN revision 55933:

Fix [disallow_end_turn] persisting when advancing to the next scenario (bug #20351)

Do this by resetting can_end_turn to true in the middle of the scenario
transition work. This is probably not the best fix, but it works.

(Browse SVN revision 55933)

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.
Wed 05 Dec 2012 05:15:34 AM UTC, original submission:

The effects of the [disallow_end_turn] WML action persist when advancing scenarios ([endlevel], :n, etc.) in Wesnoth 1.10.x, making it necessary to use [allow_end_turn] on the next scenario to restore the normal state.

Steps to reproduce:
- Insert a [disallow_end_turn] action in a scenario's prestart event and run the scenario. Make sure the next scenario does not have a [disallow_end_turn] action in any initial events.
- Try to end your turn; you will be presented with a message stating you are not allowed to end your turn yet.
- Use :debug :n to advance to the next scenario.
- Try to end your turn; you will still be unable to end your turn.

This does not appear to affect trunk.

Ignacio R. Morelle <shadowmaster>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:27:34 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Tue 25 Dec 2012 10:38:38 PM UTCshadowmasterStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup