Oh, I see. This crash only occurred if 'pamcakes' was completely detached at '/delegate take' time, I guess -- if they were an observer (or player), all would be fine.

Do not attempt to attach a connection to a player or to global observer when
restoring delegation if the connection was not previously attached to something.
It was causing the server creating an incomplete player for it. Many assertion
failures and eventually a crash were consequences.

Reported by Jacob Nevins

See gna bug #20490

(Browse SVN revision 22397)

Oops, I missed the vital step in my description! Should have been

• ...
• pamcakes: /delegate take Ur-Nammu [herp's player]
• herp rejoins
• bad things happen to server

This is the scenario the backtraces come from.

• Two users initially: herp, derp, each with a player
• Game started
• herp: /delegate to pamcakes
• herp leaves
• pamcakes joins (not attached to player intitially)
• pamcakes: /delegate take Ur-Nammu [herp's player]
• bad things happen to server

"Bad things" include many many assertion failures and eventually a crash.

With -F, the first server assertion failure:

Without -F, I get 8112 of these assertions, then a different one, then a segfault.

(I note that this is a map of 78 x 52 = 4056 tiles, so it looks like there are two assertion failures per tile. I haven't checked if they have different backtraces.)

A similar thing happens if the delegate 'pamcakes' just leaves the game, without 'herp' reconnecting. So it may be something to do with the process of detaching the delegate from the player. This is probably the simpler case to debug, but I haven't double-checked the backtraces etc are exactly the same.