bugBattle for Wesnoth - Bugs: bug #20523, crash on loading replay from newer...

 
 
Show feedback again

bug #20523: crash on loading replay from newer version

Submitted by:  krishna e bera <tr0ll>
Submitted on:  Sun 17 Feb 2013 04:20:43 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Replays
Status: Wont FixPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.10.5Operating System: linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 23 Feb 2013 08:34:41 AM UTC, comment #4:

The game warns you try to load a save game from a different version. So you've been warned things might not work.

Regarding refusing to load newer versions. Like Anonymissimus said; that seems like a bad idea as well, things might work perfectly it just depends on the amount of changes between 10.x and the development version; a thing 10.x can't know.

Regarding graceful exit upon an assertion failure. An assertion failure should terminate the program it is upon the OS to handle that. I know Windows gives a dialogue with the assertion message and then exit. Linux terminates with an error on the terminal.

Mark de Wever <mordante>
Project Member
Sun 17 Feb 2013 10:49:33 PM UTC, comment #3:

Weird behaviour wrt game variables is expected, sure, but never a crash. It makes one suspect an exploit is possible by posting a crafted replay to the forums...
Less pathologically, users might reasonably expect that (slightly) outdated saves and replays will work in new programs but not the reverse. This is common in the word processing world.

Feel free to make it a minor bug, i missed that field when reporting it.

krishna e bera <tr0ll>
Sun 17 Feb 2013 05:43:08 PM UTC, comment #2:

Come on, this isn't a real bug. If one is loading things with a version the loaded thing wasn't created with, one needs to expect all sorts of weird behavior. But most of the time, this tends to work rather well, thus allowing to load things from different versions is actually worthwile.

Anonymissimus <anonymissimus>
Project Member
Sun 17 Feb 2013 04:23:13 PM UTC, comment #1:

here is the assertion failure, which didnt show up when i use verbatim tag

wesnoth: /home/keb/Downloads/wesnoth-1.10.5/src/game_display.cpp:1308: void game_display::set_team(size_t, bool): Assertion `teamindex < teams_.size()' failed.

krishna e bera <tr0ll>
Sun 17 Feb 2013 04:20:43 PM UTC, original submission:

reproduce: load the 1.11 replay (attached) into 1.10.5

behaviour: generates an assertion failure in .xsession-errors and then crashes.

expected:

  1. refuse to load replay from newer major verson (1.11)
  2. exit gracefully on assertion failure

(observed by pauxlo)

krishna e bera <tr0ll>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17240:  HttT-The_Siege_of_Elensefar_replay.gz added by tr0ll (36kB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mordante (Posted a comment)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by tr0ll (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:47:29 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 23 Feb 2013 08:34:41 AM UTCmordanteStatusNone=>Wont Fix
    Sun 17 Feb 2013 04:20:43 PM UTCtr0llAttached File-=>Added HttT-The_Siege_of_Elensefar_replay.gz, #17240
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup