bugFreeciv - Bugs: bug #20565, automake warning: variable...

 
 
Show feedback again

bug #20565: automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed 27 Feb 2013 12:33:54 AM UTC  
 
Category: bootstrapSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: GNU/Linux
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 08 Mar 2013 04:15:04 AM UTC, SVN revision 22500:

Removed redundant EXTRA_freeciv_manual_DEPENDENCIES variable that
was giving errors with older automake

Reported by Jacob Nevins

See bug #20565

(Browse SVN revision 22500)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 08 Mar 2013 04:14:55 AM UTC, SVN revision 22499:

Removed redundant EXTRA_freeciv_manual_DEPENDENCIES variable that
was giving errors with older automake

Reported by Jacob Nevins

See bug #20565

(Browse SVN revision 22499)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 28 Feb 2013 01:59:58 PM UTC, comment #7:

From automake-1.11.3 NEWS:

"For programs and libraries, automake now detects EXTRA_foo_DEPENDENCIES"

So it doesn't work on all automake versions we want to support, and is redundant declaration anyway.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 28 Feb 2013 10:31:19 AM UTC, comment #6:

Well, of course it's a reserved name - that's why it was used there.
EXTRA is a valid prefix for _DEPENDENCIES variables - see i.e. 'info automake1.11 Linking'.

Rafał Mużyło <galtgendo>
Wed 27 Feb 2013 06:26:36 PM UTC, comment #5:

It's an error in the sense that "_DEPENDENCIES" is reserved suffix for a automake variable name, and for that reserved meaning this variable name makes no sense.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 05:46:40 PM UTC, comment #4:

Which version of automake are you using ?
AFAICT, while the construct does look redundant in this particular case, it's nevertheless valid (that is, it shouldn't trigger an error).

Regarding the fixes: while they look OK, it seems that '../client/helpdata.lo' in freeciv_manual_LDADD should be '$(top_builddir)/client/helpdata.lo', but it doesn't look like it would make a difference.

Rafał Mużyło <galtgendo>
Wed 27 Feb 2013 07:00:38 AM UTC, comment #3:

Fixes attached

(file #17355, file #17356)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 06:23:39 AM UTC, comment #2:

That's a good warning, the line in question does nothing sensible. It came with bug #20095. It seems like something one meant to do just temporarily while developing/testing the patch (not yet removing dependency list completely, but renaming it to dummy name), but then forgot to final one.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 12:37:04 AM UTC, comment #1:

Actually this is happening on S2_4 as well (only it's manual/Makefile.am there).

Jacob Nevins <jtn>
Project Administrator
Wed 27 Feb 2013 12:33:54 AM UTC, original submission:

Recently I've been getting the following warning when automake runs (e.g. as part of autogen.sh):

The relevant bit of tools/Makefile.am is:

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17355:  ManualDepLdadd.patch added by cazfi (727B - text/x-diff)
file #17356:  ManualDepLdadd-S2_4.patch added by cazfi (731B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Mar 2013 04:15:17 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 27 Feb 2013 07:00:37 AM UTCcazfiAttached File-=>Added ManualDepLdadd.patch, #17355
      Attached File-=>Added ManualDepLdadd-S2_4.patch, #17356
      StatusNone=>Ready For Test
    Wed 27 Feb 2013 12:37:04 AM UTCjtnPlanned Release2.5.0=>2.4.0,2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup