bugBattle for Wesnoth - Bugs: bug #20676, gold carryover broken in...

 
 
Show feedback again

bug #20676: gold carryover broken in DiD::Endless Night

Submitted by:  Anonymissimus <anonymissimus>
Submitted on:  Thu 28 Mar 2013 08:13:30 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Anja K <ayne>Open/Closed: Closed
Release: 1.11.2+svn@r56594Operating System: win xp

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 03 Apr 2013 03:22:44 PM UTC, comment #5:

Done in
1.11.2-99-g873f3a7

Anonymissimus <anonymissimus>
Project Member
Wed 03 Apr 2013 11:32:18 AM UTC, comment #4:

I added a patch that takes care of that little logic error. I don't have a dev account for Sourceforge yet and it doesn't seem worth getting one until the current situation is resolved, so if you could test it again and commit it, I would be much obliged.

(file #17666)

Anja K <ayne>
Project MemberIn charge of this item.
Sun 31 Mar 2013 05:17:12 PM UTC, comment #3:

Uh, i just checked again, and I'm apparently wrong about the "Normally it works". I did only notice in the scenario mentioned in the title, since it is easy to notice there.
Well, then the situation is simpler at least and it's a regular logic error.

Anonymissimus <anonymissimus>
Project Member
Sun 31 Mar 2013 05:06:45 PM UTC, comment #2:

"To sum this up, you're saying that a negative carryover should be ignored so the next scenario will start with the defined minimum starting gold? "
Yes, exactly. That is the way it used to be, and also what the dialog says.
Do note that during the very same playthrough of the campaign there was such a case in another scenario, and I started with the minimum gold in the next one. This is the "Normally it works though".
There are quite a number of mainline scenarios which would basically prevent players from continuing the campaign, since they are unbeatable without recalling almost everything.

Anonymissimus <anonymissimus>
Project Member
Sat 30 Mar 2013 05:33:08 PM UTC, comment #1:

To sum this up, you're saying that a negative carryover should be ignored so the next scenario will start with the defined minimum starting gold?
At first glance I can't see any implementation of this behaviour in previous versions, but it should be easy enough to add.

Anja K <ayne>
Project MemberIn charge of this item.
Thu 28 Mar 2013 08:13:30 PM UTC, original submission:

1. Start a new Descend into Darkess playthrough, :debug and :cl to 12_Endless_Night.cfg.
2. :gold -210 to set side 1's current gold to -10.
3. :unit hitpoints=-1 on the enemy leader, debug-create a unit, kill him. Notice how the endlevel dialog says that we'll start with the minimum gold in the next scenario, which is set to 200 in the side definition. (:n is not enough, we need to end the scenario normally.)
4. In the next iteration of the scenario, we have less than 200 gold. (It was 196; 200-10*(40/100) probably.)

Normally it works though (setting the start gold to the minimum if we had negative carryover). I also recall that the carryover in this scenario worked in earlier versions. Thus this happens probably because of the special nature of this scenario (next scenario is the same as current one); and perhaps since the changes to carryover in summer 2012, I didn't check whether it also happens in 1.10 however.
The turn limit is -1 here, while [endlevel]bonus=yes which doesn't make sense.

Anonymissimus <anonymissimus>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17666:  gold.patch added by ayne (357B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by ayne (Posted a comment)
  • -unavailable- added by anonymissimus (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 13 Jun 2013 08:52:57 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Wed 03 Apr 2013 03:22:44 PM UTCanonymissimusStatusNone=>Fixed
      Assigned toNone=>ayne
    Wed 03 Apr 2013 11:32:18 AM UTCayneAttached File-=>Added gold.patch, #17666
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup