bugMyPaint - Bugs: bug #20730, Symmetry mode eats horizontal...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #20730: Symmetry mode eats horizontal strokes of classic/kinfe brush with radius 1.10

Submitted by:  Libra Rian <zrzz>
Submitted on:  Tue 09 Apr 2013 04:38:54 PM UTC  
 
Severity: 3 - NormalPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 819eae4Planned Release: None
Operating System: Lubuntu 12.10/Compiz

Mon 22 Apr 2013 12:56:43 AM UTC, comment #2:

Cool bug! Thanks for the fix: tested and pushed.

https://gitorious.org/mypaint/mypaint/commit/6f8c5bc95cb919e483a43b48607494fc6f19ce06

Andrew Chadwick <achadwick>
Project Administrator
Sat 20 Apr 2013 06:15:36 AM UTC, comment #1:

FOUND IT!FOUND IT!FOUND IT!FOUND IT!

Symmetry mode is broken due type conversion. Look at draw_dab(brushlib/mypaint-tiled-surface.c:587). When applying symmetry mode it converts float x to int symm_x. And that breaks things

Fix in this commit

https://gitorious.org/~zrzz/mypaint/librarian-mypaint/commit/6403715c8a8868e0e044ae9081d55cf9606940e4

Libra Rian <zrzz>
Tue 09 Apr 2013 04:38:54 PM UTC, original submission:

Funny thing that is triggered under very specific conditions:

1) Launch mypaint
2) Select classic/knife brush, decrease radius to 1.10
3) Turn on symmetry mode
4) Draw line as horizontal as you can. Mouse or tablet - does not matter.

Symmetry mode will not reproduce horizontal lines correctly. Only horizontal lines. And only for radius=1.10. Other lines and radiuses are fine.

Now interesting part: open brush settings(Ctrl-B), click "update last stroke" and change brush radius. Horizontal stroke with radius != 1.10 will be symmetrically drawn more correctly.

Attach has two screenshots where I update radius. Notice that at radius=1.10 stroke in symmetry-drawn part is invisible.

Libra Rian <zrzz>

 

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by achadwick (Posted a comment)
  • -unavailable- added by zrzz (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 22 Apr 2013 12:56:43 AM UTCachadwickStatusNone=>Ready For Test
    Tue 09 Apr 2013 04:38:54 PM UTCzrzzAttached File-=>Added 2013-04-09-232438_1280x960_scrot.png, #17726
      Attached File-=>Added 2013-04-09-232456_1280x960_scrot.png, #17727
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup