bugFreeciv - Bugs: bug #20750, packets.c:send_packet_data():...

 
 
Show feedback again

bug #20750: packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 20 Apr 2013 09:58:51 AM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4 r22731Operating System: GNU/Linux
Planned Release: 2.3.5, 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Aug 2013 09:07:29 PM UTC, SVN revision 23160:

Fixed 'variable set but not used' -compiler warning from non-debug builds.

Reported by Jacob Nevins
Patch by pepeto

See bug #20750

(Browse SVN revision 23160)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 06 Aug 2013 09:07:23 PM UTC, SVN revision 23159:

Fixed 'variable set but not used' -compiler warning from non-debug builds.

Reported by Jacob Nevins
Patch by pepeto

See bug #20750

(Browse SVN revision 23159)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 15 May 2013 10:49:38 AM UTC, comment #1:

Patch attached for S2_4. It applies cleanly to S2_3 too.

Note this warning shouldn't appear in S2_5 and trunk.

(file #17969)

pepeto <pepeto>
Project Member
Sat 20 Apr 2013 09:58:51 AM UTC, original submission:

Noticed scrolling by while making a test S2_4 release build:

Since this wasn't an --enable-debug=yes build (no -Werror), this warning didn't stop the build. In fact it looks like this will only show up when debugging is off, because the variable is only used if DEBUG is defined, so it'll never break the build. Should still clean it up though.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17969:  send_packet_data.diff added by pepeto (1kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Aug 2013 09:07:39 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 04 Aug 2013 07:54:54 PM UTCcazfiCategoryNone=>general
      Assigned toNone=>cazfi
      Planned Release2.4.0=>2.3.5, 2.4.0
    Wed 15 May 2013 10:49:38 AM UTCpepetoAttached File-=>Added send_packet_data.diff, #17969
      StatusNone=>Ready For Test
      Planned Release2.4.0,2.5.0=>2.4.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup