bugBattle for Wesnoth - Bugs: bug #20836, harm_unit doesnt fire advance...

 
 
Show feedback again

bug #20836: harm_unit doesnt fire advance event when experience=yes

Submitted by:  None
Submitted on:  Wed 22 May 2013 12:50:43 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Elvish_Hunter <elvish_hunter>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 10.6
Operating System: win 7 64

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 27 Jun 2013 10:04:10 AM UTC, comment #4:

OOS-triggering changes are not allowed in maintenance branches.

Closing this bug since a development release with the fix is out now and it won't be fixed in 1.10.x.

Ignacio R. Morelle <shadowmaster>
Project Administrator
Tue 18 Jun 2013 03:14:54 PM UTC, comment #3:

Then don't I say.

Anonymissimus <anonymissimus>
Project Member
Sun 16 Jun 2013 02:45:02 PM UTC, comment #2:

Fixed in master: http://git.io/YWkPPA .
I'm undecided if this should be backported to the 1.10 series, due to the risk of OoS errors.

Elvish_Hunter <elvish_hunter>
Project MemberIn charge of this item.
Wed 22 May 2013 04:44:37 PM UTC, comment #1:

thread this came from: http://forums.wesnoth.org/viewtopic.php?f=4&t=38847&p=553752#p553752
@Elvish_Hunter: You probably just have to add fire_event=yes where he says and/or make it a parameter to harm_unit, to account for mainline commit 8692f22dc5f9d0c9e1b64ea7df8594141f39c362, in which I added [unstore_unit]fire_event= with default no, while the previous implicit default was yes. You know the tag best so I assign it to you.

Anonymissimus <anonymissimus>
Project Member
Wed 22 May 2013 12:50:43 PM UTC, original submission:

my problem is:
harm_unit doesnt fire post advance event when experience=yes.

i think the reason is, that harm_unit uses unstrore_unit at the end of the lua function with advance = yes and fire_event = no by default.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Posted a comment)
  • -unavailable- added by elvish_hunter (Posted a comment)
  • -unavailable- added by anonymissimus (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 27 Jun 2013 10:04:10 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sun 16 Jun 2013 02:45:02 PM UTCelvish_hunterStatusNone=>Fixed
    Wed 22 May 2013 04:44:37 PM UTCanonymissimusAssigned toNone=>elvish_hunter
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup