bugBattle for Wesnoth - Bugs: bug #21266, for clang-based system missed...

 
 
Show feedback again

bug #21266: for clang-based system missed header for typedef time_t

Submitted by:  None
Submitted on:  Sat 09 Nov 2013 04:40:33 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 10.0
Operating System: FreeBSD

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 02 Feb 2014 09:18:12 AM UTC, comment #3:

Fixed in d07af9a0ada4.

Alexander van Gessel <ai0867>
Project Member
Sun 02 Feb 2014 03:40:57 AM UTC, comment #2:

Somewhere between 1.11.2 and current (a2e1c2c) git master, another instance of this seems to have been introduced, the following diff fixes the build for me:

diff --git a/src/format_time_summary.hpp b/src/format_time_summary.hpp
index 68fa5b2..542ac7a 100644
--- a/src/format_time_summary.hpp
+++ b/src/format_time_summary.hpp
@@ -18,6 +18,7 @@
#include "global.hpp"

#include <string>
+#include <time.h>

namespace util {
std::string format_time_summary(time_t t);

Anonymous
Mon 20 Jan 2014 03:24:52 AM UTC, comment #1:

This was fixed in 1.11.2 and I've just backported the fix to 1.10, in case there's ever a 1.10.8

Alexander van Gessel <ai0867>
Project Member
Sat 09 Nov 2013 04:40:33 PM UTC, original submission:

On clang based system (FreeBSD, MacOSX) compilation is broken due to missed headers for time_t;

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183627

Please review follow patches

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19339:  patch-src-chat_events.hpp added by None (230B - text/x-c++hdr)
file #19340:  patch-src-server-metrics.hpp added by None (225B - text/x-c++hdr)
file #19341:  patch-src-server-user_handler.cpp added by None (370B - text/x-c++src)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by ai0867 (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 10 Feb 2014 12:37:54 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Mon 20 Jan 2014 03:24:52 AM UTCai0867StatusNone=>Fixed
    Sat 09 Nov 2013 04:40:33 PM UTCNoneAttached File-=>Added patch-src-chat_events.hpp, #19339
      Attached File-=>Added patch-src-server-metrics.hpp, #19340
      Attached File-=>Added patch-src-server-user_handler.cpp, #19341
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup