bugBattle for Wesnoth - Bugs: bug #21290, Unit names and ids are not synced...

 
 
Show feedback again

bug #21290: Unit names and ids are not synced in MP and replays

Submitted by:  Matthias Schoeck <mattsc>
Submitted on:  Wed 20 Nov 2013 10:43:48 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 3 - LowItem Group: Units
Status: NonePrivacy: Public
Assigned to: Matthias Schoeck <mattsc>Open/Closed: Open
Release: 1.11.7Operating System: OS X 10.8

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 25 Nov 2013 02:26:00 AM UTC, comment #1:

The names are now synced as of commit 071b7550f9cf1fafb0d46a7c9f3704de0d8bc737. While doing that I noticed that unit genders were also not synced. That has also been fixed.

Also, I changed my mind about this problem not causing OOS errors. It was, in fact, quite easy to come up with test cases that caused OOS errors before names and genders were synced.

ids and underlying_ids are not synced yet and there is some question as to whether that's necessary.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.
Wed 20 Nov 2013 10:43:48 PM UTC, original submission:

Take any replay and play a turn in which units are recruited. Take note of the names of the recruited units. Then play the same replay turn again. The names are now different, as are the unit ids (and underlying_ids, in fact).

The same is true for the units in a MP game. Each player will see different names for units that do not have assigned names.

We propose to fix this and have at least the names synced for replays and MP games. It does likely not cause OOS errors (as these attributes are only accessible by extracting them from the unit first and each host/client/replay will do this correctly for its own situation), but at the very least it seems inelegant to have the same units in a MP game have different names for different players.

Matthias Schoeck <mattsc>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mattsc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 25 Nov 2013 02:26:00 AM UTCmattscAssigned toNone=>mattsc
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup