bugFreeciv - Bugs: bug #21692, Flag display mangled + assertion...

 
 
Show feedback again

bug #21692: Flag display mangled + assertion failures

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed 19 Feb 2014 12:32:47 AM UTC  
 
Category: client-gtk-3.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Duplicate
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4 r24515, trunkOperating System: GNU/Linux
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 24 Aug 2014 10:15:58 PM UTC, comment #2:

I think bug #22457 fixed all this.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 13 Jul 2014 10:52:00 PM UTC, comment #1:

> 1: in get_flag() [plrdlg.c::599]: assertion 'x0 != -1' failed.


Backtrace about that:

#2 0x00000000004662c5 in get_flag (nation=0x46ab)
at client/gui-gtk-3.0/plrdlg.c:600
x0 = -1
y0 = -1
x1 = -1
y1 = -1
w = 17703888
h = 47086896
im = 0x4259510
flag = 0x318b190
_FUNCTION_ = "get_flag"
#3 0x00000000004633f0 in real_conn_list_dialog_update ()
at client/gui-gtk-3.0/pages.c:2315
pplayer = 0x2ce7d30
parent = {stamp = 110, user_data = 0x7ffff40bd620 <main_arena>,
user_data2 = 0x3a0, user_data3 = 0x112}
pprev_parent = 0x0
rating_text = "\016\000\000\000\000\000\000\000>\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\\", '\000' <repeats 23 times>, "n\000\000\000w", '\000' <repeats 11 times>, "|", '\000' <repeats 15 times>, "n\000\000\000w\000\000\000 \326\v\364\377\177\000\000\240\003\000\000\000\000\000\000\022\001\000\000\000\000\000\000\260\325g\000\000\000\000\000\000\031\267\003\000\000\000"
prev_parent = {stamp = 6804912, user_data = 0x3b85450, user_data2 = 0x5,
user_data3 = 0x70}
pselected_player = 0x0
access_level = 17703888
prev_child = {stamp = 110, user_data = 0x0, user_data2 = 0x7c,
user_data3 = 0x0}
collapsed = 976
pselected_conn = 0x0
child = {stamp = 1, user_data = 0x5c, user_data2 = 0x0, user_data3 = 0x0}
model = 0x10d5f20
user_name = "|\000\000\000\000\000\000\000p\026`\000\001", '\000' <repeats 11 times>, " \326\v\364\377\177\000\000D\300\310\000\000\000\000\000\000\020\000\000\000\000\000\000;\000\000\000\000\000\000"
record_text = "\340\330_\000\000\000\000\000 b\331\363\377\177\000\000\260\325g\000\000\000\000\000\240\003\000\000\000\000\000\000\020\331a\000\000\000\000\000\257\025`", '\000' <repeats 13 times>, "\240\003", '\000' <repeats 30 times>, "p\026`", '\000' <repeats 13 times>, "\020rL", '\000' <repeats 13 times>, "i\327_\000\000\000\000"
path = 0x2ce7d30
pprev_child = 0x0
_FUNCTION_ = "real_conn_list_dialog_update"
#4 0x00000000004c71a2 in update_unqueue (data=<optimized out>)
at client/update_queue.c:317
callback = 0x462ea0 <real_conn_list_dialog_update>
uq_data = <optimized out>
MY_mem_MY_iter = 0x7fffffffdcc0 "\320\325_"
MY_it_MY_iter = 0x7fffffffdcc0
hash = 0x4259510
#5 0x000000000044ba2a in idle_callback_wrapper (data=0x1a7dff0)
at client/gui-gtk-3.0/gui_main.c:2074
cb = 0x1a7dff0
#6 0x00007ffff453dce5 in g_main_context_dispatch ()
from /lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#7 0x00007ffff453e048 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#8 0x00007ffff453e30a in g_main_loop_run ()
from /lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#9 0x00007ffff5fe8735 in gtk_main () from /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#10 0x000000000044df7e in ui_main (argc=1, argv=0x7fffffffe318)
at client/gui-gtk-3.0/gui_main.c:1700
toplevel_font_name = <optimized out>
sig = <optimized out>
_FUNCTION_ = "ui_main"
#11 0x0000000000474c97 in client_main (argc=2, argv=0x7fffffffe318)
at client/client_main.c:599
i = 2
loglevel = LOG_NORMAL
ui_options = 1
ui_separator = false
user_tileset = false
fatal_assertions = 6
aii = 1
_FUNCTION_ = "client_main"
#12 0x00007ffff3d3bb45 in __libc_start_main (main=0x44b380 <main>, argc=2,
argv=0x7fffffffe318, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>, stack_end=0x7fffffffe308) at libc-start.c:287
result = <optimized out>
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 7196456029289926500,
4502405, 140737488347920, 0, 0, -7196456029649154204,
-7196447613402394780}, mask_was_saved = 0}}, priv = {pad = {0x0,
0x0, 0x61ca30 <__libc_csu_init>, 0x7fffffffe318}, data = {
prev = 0x0, cleanup = 0x0, canceltype = 6408752}}}
not_first_call = <optimized out>
#13 0x000000000044b3ae in _start ()

(gdb) p flag
$1 = (struct sprite *) 0x318b190

so it's not NULL flag, but problem seems to be in sprite_get_bounding_box().

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 19 Feb 2014 12:32:47 AM UTC, original submission:

Certain nation flags are displayed incorrectly in the Gtk3 client's GUI widgets (e.g. "pick nation" dialog, F3 Nations report), although they are displayed fine on the main map.

Symptoms seem to be that flags are cropped to only include a central symbol, sometimes losing all identity (e.g. Italian tricolor).

Attached examples with S2_4 r24515 demonstrate the issue:

  • Arab flag cropped to central symbol
  • German flag absent? (Row height less than other rows
  • Inca flag shortened vertically
  • Indian flag lost top stripe
  • Italian flag has become just central white stripe (only visible with cursor)
  • Outlines generally absent compared to Gtk2 client

Also I get a long mixture of the following two assertion failures on the console when opening "Pick Nation" (the first is much more common):

Not sure how I would have failed to notice this while working on nation sets, so maybe it's a recent regression (in Freeciv or Gtk, although I'm still using the same distro version I was before).

This may be somehow related to bug #21373.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20109:  cropped-arab.png added by jtn (13kB - image/png - screen grabs from S2_4 r24515 Gtk3 client)
file #20110:  cropped-various.png added by jtn (29kB - image/png - screen grabs from S2_4 r24515 Gtk3 client)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 24 Aug 2014 10:15:58 PM UTCcazfiStatusNone=>Duplicate
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 19 Feb 2014 12:32:47 AM UTCjtnAttached File-=>Added cropped-arab.png, #20109
      Attached File-=>Added cropped-various.png, #20110
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup