bugBattle for Wesnoth - Bugs: bug #21758, Ready not blocked while player...

 
 
Show feedback again

bug #21758: Ready not blocked while player pick faction.

Submitted by:  None
Submitted on:  Wed 05 Mar 2014 04:59:16 PM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Multiplayer Lobby
Status: FixedPrivacy: Public
Assigned to: Andrius Silinskas <thunderstruck>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 1.11.11
Operating System: Mac OSX 10.6.8

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 13 Oct 2014 11:55:29 PM UTC, comment #6:

Marking as fixed and closing.

Chris Beck <involution>
Project Member
Mon 17 Mar 2014 01:22:30 PM UTC, comment #5:

Proposed fix is on master.

Chris Beck <involution>
Project Member
Sat 08 Mar 2014 06:43:50 PM UTC, comment #4:

I'm wrong again, it turns out this is actually quite old and not actually that broken... we'll see what others who worked on this code say.

Chris Beck <involution>
Project Member
Thu 06 Mar 2014 10:30:46 PM UTC, comment #3:

I'm sorry, you are right, this somehow has gotten seriously broken in master. I will try to figure out what commit caused this, it must have been very recent.

Chris Beck <involution>
Project Member
Wed 05 Mar 2014 10:30:45 PM UTC, comment #2:

Specifically, I think your claim about the button is false -- the start button doesn't activate until all players have selected factions. It's only the "ready to start" text that is slightly buggy.

See also discussion here: https://github.com/wesnoth/wesnoth/pull/85

Chris Beck <involution>
Project Member
Wed 05 Mar 2014 10:28:16 PM UTC, comment #1:

I don't think this is actually true.

Currently, as I understand, the host may not start the game until all players have chosen factions, but the text "Ready to start..." will appear as soon as all available slots have appeared.

This is a minor bug, in that it misleads the players into thinking that the host is stalling.

But if the situation were as you describe, it would really be a major bug, as there is no way the host can generate the WML for the level and send it out until the leaders for all sides have been determined. I'm quite certain this is not the case right now.

Chris Beck <involution>
Project Member
Wed 05 Mar 2014 04:59:16 PM UTC, original submission:

When a host is waiting for a game to start and the last slots are filled he may start the game immediately even though other players have not yet selected faction (As evidenced by the fact that the button to start the game activates as soon as they join despite factions being selected several seconds later).

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by thunderstruck (Updated the item)
  • -unavailable- added by involution (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 13 Oct 2014 11:55:29 PM UTCinvolutionStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 17 Mar 2014 01:22:30 PM UTCinvolutionStatusConfirmed=>Ready For Test
    Sat 08 Mar 2014 07:16:55 PM UTCthunderstruckAssigned toNone=>thunderstruck
    Thu 06 Mar 2014 10:33:55 PM UTCinvolutionStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup