bugBattle for Wesnoth - Bugs: bug #21800, a side with controller=null is...

 
 
Show feedback again

bug #21800: a side with controller=null is shown in the game lobby

Submitted by:  SlowThinker <slowthinker>
Submitted on:  Sat 15 Mar 2014 05:19:21 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer Lobby
Status: InvalidPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.11.11Operating System: Windows XP

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 29 May 2014 09:17:33 PM UTC, comment #15:

My previous post is invalid.

And I can confirm the problem described in comment #12 has been patched in BfW 1.11.15

SlowThinker <slowthinker>
Thu 29 May 2014 07:54:32 PM UTC, comment #14:

the problem continues in 1.11.15

SlowThinker <slowthinker>
Mon 19 May 2014 05:17:05 AM UTC, comment #13:

SlowThinker: I looked into this. I don't think that the lack of a proper option in the combo box was actually corrupting the side settings of debug mode games, from inspecting save files it seems it had no effect, although perhaps if you clicked on a combo box option it would.

But anyways I have patched this issue in 1.12 and master, thank you for reporting.

http://git.io/o3wqnQ

Chris Beck <involution>
Project Member
Mon 05 May 2014 10:21:09 PM UTC, comment #12:

Maybe I found out when the "bug" happens: It happens in the debug mode.
And it sounds reasonable that in the debug mode players can control also sides with 'allow_player=no' (or 'controller=null'? All occurences I found had both 'allow_player=no' and 'controller=null').

But I still see a little bug there: The team of the side with 'allow_player=no'/'controller=null' is automatically changed to the side1's team, and maybe there are more changes in the side's properties.

SlowThinker <slowthinker>
Tue 08 Apr 2014 09:18:27 PM UTC, comment #11:

I've marked this as 'invalid' for now. Let us know if the problem happens again.

Andrius Silinskas <thunderstruck>
Project Member
Thu 20 Mar 2014 11:49:36 PM UTC, comment #10:

My mistake: Sulla's ruins contains a side with 'allow_player=no'.

Now I have no idea what triggers/removes the bug. I got the bug again (just for scenarios with 'allow_player=no'), I removed the file with preferences but the bug stayed. I reinstalled BfW 1.11.11 and so far I am not able to trigger the bug.

SlowThinker <slowthinker>
Wed 19 Mar 2014 03:41:49 AM UTC, comment #9:

Hmm... I can't seem to reproduce this with your preferences file.

Chris Beck <involution>
Project Member
Tue 18 Mar 2014 05:52:18 PM UTC, comment #8:

I attached my preferences.
But I suspect the preferences needn't be the triger that caused the bug. Maybe only the removal of preferences forced BfW to reset things and to clear the bug effect.

(file #20388)

SlowThinker <slowthinker>
Mon 17 Mar 2014 08:44:12 PM UTC, comment #7:

Can you post your 1.10 preferences file? I will try to reproduce with mine but regardless it would be good to have yours to track down whatever went wrong here.

Chris Beck <involution>
Project Member
Mon 17 Mar 2014 05:50:49 PM UTC, comment #6:

Result of more tests:

The problem has nothing common with allow_player=
This is a screenshot of a standard scenario:
http://imgur.com/rUDXxnz

It looks it was the file wesnoth_user_data_directory/preferences that caused the problem:
My BfW 1.11.11 behaved correctly until I copied 'preferences' from BfW 1.10.
From that point any game had one additional side (see screenhots).
Once I removed 'preferences' the bug dissapeared.
Then I was unable to reproduce it with any 'preferences', even those from BfW 1.10.

SlowThinker <slowthinker>
Mon 17 Mar 2014 04:06:19 PM UTC, comment #5:

I loaded the file from the user data directory: data/add-ons
This is my screenhot:
http://imgur.com/zHLpLfh

notice user_team_name=Neutrals is ignored

(Off topic: This bug seems to be system-specific
http://forums.wesnoth.org/viewtopic.php?f=4&t=37835
)

SlowThinker <slowthinker>
Mon 17 Mar 2014 02:40:15 PM UTC, comment #4:

Here's my screenshot from loading that file, after substituting it for the core den of onis file, in current 1.12 branch (=1.11.11+dev) of wesnoth:

http://imgur.com/57ADQSs

I seriously doubt that it is platform-specific but I guess it is possible?

Chris Beck <involution>
Project Member
Sun 16 Mar 2014 02:07:05 PM UTC, comment #3:

>Currently "controller=null" will just make the side be assigned "empty" by default, afaik.


Yes, and I think it is a better behaviour than in 1.10.
controller= should not interfere with allow_player= IMO

>Are you sure that this isn't working? Can you provide a test file?


For me next code shows side 2 as 'Empty' with BfW 1.11.11:

SlowThinker <slowthinker>
Sun 16 Mar 2014 06:41:32 AM UTC, comment #2:

"Anyway in Wesnoth 1.11 allow_player=no is ignored."

From tests I was just doing on this other bug, I don't think that this is ignored.

https://gna.org/bugs/index.php?21797

And it appears in the source code that this is indeed the only variable that controlelrs whether it is shown.

https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_connect.cpp#L421

Currently "controller=null" will just make the side be assigned "empty" by default, afaik.

https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_connect_engine.cpp#L868

Are you sure that this isn't working? Can you provide a test file?

Chris Beck <involution>
Project Member
Sun 16 Mar 2014 12:48:30 AM UTC, comment #1:

Now I noticed allow_player= should control whether the side is shown in the game lobby.
(In Wesnoth 1.10 controller=null prevents the side is shown too, for some reason unknown to me)

Anyway in Wesnoth 1.11 allow_player=no is ignored.

SlowThinker <slowthinker>
Sat 15 Mar 2014 05:19:21 PM UTC, original submission:

Wesnoth 1.10 didn't show such a side in the list of sides.

SlowThinker <slowthinker>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20388:  preferences.slowthinker added by slowthinker (45kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by thunderstruck (Posted a comment)
  • -unavailable- added by involution (Posted a comment)
  • -unavailable- added by slowthinker (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Apr 2014 01:01:42 AM UTCshadowmasterOpen/ClosedOpen=>Closed
    Tue 08 Apr 2014 09:18:27 PM UTCthunderstruckStatusNone=>Invalid
    Tue 18 Mar 2014 05:52:18 PM UTCslowthinkerAttached File-=>Added preferences.slowthinker, #20388
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup