|
Fri 08 Dec 2006 11:13:41 PM UTC, comment #12:
Uh, I never noticed that I used a quite ambigous phrase. OK, I'll try tomorrow now that we understand each other :) Major problem is to install Savane locally...
|
Fri 08 Dec 2006 11:10:16 PM UTC, comment #11:
> Look, there is most certainly a major misunderstanding.
That's what I thought. :)
Actually, when you wrote "You can see on the top page", I understood "You can see on the top of the page", as I usually refer to this page as the front page or site homepage.
So now I understand what you meant and all make sense. Please accept my apologies.
Now, back to this point, this cosmetic improvement does not require branching, indeed. Go ahead :)
This approach is already done when you have long links in items, for instance:
http://thisisalongurl/thisisalongurl/thisisalongurl/thisisalongurl/thisisalongurl/thisisalongurl/thisisalongurl/
BTW, I think there should be only one link ("sr #nnn: TITLE") and not two links separated by ":" ("sr #nnn" : "TITLE").
|
Fri 08 Dec 2006 10:09:11 PM UTC, comment #10:
Look, there is most certainly a major misunderstanding. This bug is not about page titles of whatever pages. It is all about the way items are shown in feature box on the top page and most likely in many other pages.
Long item names are truncated to 30 characters and below that to the last word end, as in your code. That is fine. What I propose is that complete name in such cases is added to the resulting link (<a>) element as title="..." attribute. This is completely different matter than <title> element in page <head>.
This way, truncated names will still be shown as it is now, because otherwise long names will break site layout. But, full (untruncated) names can be known from tooltip, by hovering the mouse pointer over the truncated name.
I don't how to express it in other words...
|
Fri 08 Dec 2006 09:56:40 PM UTC, comment #9:
Paul,
features_boxes.php is unrelated to item summary that shows up truncated in the <head> of the html and on the top of page.
Page title is obtained using context_title(). context_title() cannot simply returns HTML as it is used in place where HTML is unwanted. We can certainly do something about it, but as I said in comment #1, it is not just a matter of adding a <a title="XXX">, it is also a matter of checking context_title() can legitimately return HTML (that can be solved by adding and argument like context_title($nohtml=true))
So, as I said before:
> There is actually a reason why this would not be as trivial as it seems. The title is a string used in several places, most notably also to set the whole page title, in the html head. So it would require more changes than just adding the title, in order for it not to break anything else.
|
Fri 08 Dec 2006 09:40:18 PM UTC, comment #8:
From `frontend/php/include/features_boxes.php':
So you still don't do it? I suggest to write a function for it. There must be other cases when item name is truncated in a similar way.
|
Fri 08 Dec 2006 09:23:41 PM UTC, comment #7:
Check the code, we dont do what you described. What we do is what I described in my previous comments.
|
Fri 08 Dec 2006 07:50:51 PM UTC, comment #6:
They don't need to contain HTML in any form. What you do is essentially like this:
I just propose to do
instead.
|
Fri 08 Dec 2006 08:39:23 AM UTC, comment #5:
As I said, the string we are talking about is used in <head><title> so it cannot contain any HTML.
|
Thu 07 Dec 2006 10:14:43 PM UTC, comment #4:
I don't want to put <a>'s in page title. I propose to add one more attribute to links with truncated text! Please try this:
|
Thu 07 Dec 2006 09:55:47 PM UTC, comment #3:
You cannot put <a> in <head><title>. But that where the title string is used primarily.
|
Thu 07 Dec 2006 07:08:45 PM UTC, comment #2:
Are we speaking of the same thing? I meant they could be written like <a href="..." title="A very long name">A very...</a>, with name truncated, but present fully in a tooltip.
|
Thu 07 Dec 2006 11:25:57 AM UTC, comment #1:
There is actually a reason why this would not be as trivial as it seems. The title is a string used in several places, most notably also to set the whole page title, in the html head. So it would require more changes than just adding the title, in order for it not to break anything else.
|
Mon 04 Dec 2006 08:40:47 PM UTC, original submission:
You can see on the top page: ''"bug #800: [wishlist] option to open a..., 90 votes"''. The link should have title="..." attribute so that one can find the full name of an item without following the link, just from a tooltip.
|
Related Recipes:
Savane - Bugs: bug #7929, tooltip for trucated item names in...