patchFreeciv - Patches: patch #1301, [Metaticket] settings patch series

 
 
Show feedback again

patch #1301: [Metaticket] settings patch series

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Sun 13 Sep 2009 08:58:18 PM UTC  
 
Category: generalPriority: 3 - Low
Status: DonePrivacy: Public
Assigned to: Matthias Pfafferodt <syntron>Open/Closed: Closed
Planned Release: 2.3.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 28 Oct 2011 09:29:53 PM UTC, comment #13:

Close this one only, I think. Since you've given it away I'll do it :)

The tickets about gaps should stay open -- if anyone pops up to care for those clients, that's one of the first things that should be looked at IMO.

Jacob Nevins <jtn>
Project Administrator
Fri 28 Oct 2011 09:27:49 PM UTC, comment #12:

So, closing the remaining tickets?

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 28 Oct 2011 09:00:29 PM UTC, comment #11:

The only outstanding tickets this depends on are the gaps in option type support in the SDL and Xaw clients. Everything else went in 2.3.0.
While I don't like those gaps, I don't think there's any point keeping this ticket open.

Jacob Nevins <jtn>
Project Administrator
Fri 28 Oct 2011 08:59:57 PM UTC, comment #10:

I'm not familiar with sdl or xaw client (remaining open patches) nor do I know the pepetos plans for the settings (comment #8). Removing the target and setting this to postphoned. I will do similar changes to the dependencies.

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Thu 27 Oct 2011 09:57:46 PM UTC, comment #9:

Given to syntron so he can decide what to do with this ticket.

Marko Lindqvist <cazfi>
Project Administrator
Sat 20 Feb 2010 03:42:53 PM UTC, comment #8:

> I don't know if I can help you with regard to the points you
> listed but I will try.


I just posted a step next. I guess the next one would be to merge the server settings on client side behind the same interface, adding a server_option class.

pepeto <pepeto>
Project Member
Sat 20 Feb 2010 02:33:46 PM UTC, comment #7:

OK; than it is your ticket again ;-) I don't know if I can help you with regard to the points you listed but I will try.

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Sat 20 Feb 2010 01:13:13 PM UTC, comment #6:

Hm, actually, I have many other project about server settings before closing this metaticket:

  • Adding more settings types: notably select enum names instead of magic values for the options which use them (e.g. topology or generator and so many others).
  • Use a common interface for client or server options in the client side.
  • Update the gui stuff to be more user friendly (notably adding the improvements of warclient).
pepeto <pepeto>
Project Member
Sat 20 Feb 2010 12:57:42 PM UTC, comment #5:

closing this patch entry - all dependencies are applied or closed.

Thanks to all who help improving this patch series, especially pepeto! (sorry; I nicked this patch from you to say this ;-) )

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 05 Feb 2010 10:04:57 PM UTC, comment #4:

Updated status of the settings patch series:

[01/06] patch #1200 - game settings can be locked by the ruleset
[02/06] patch #1300 - add 'show locked' command
[03/06] patch #1298 - Documentation of the setting changes in the ruleset
[04/06] patch #1198 - show changed game settings after reset and rulesetdir
[05/06] patch #1284 - update reset command (WIP)
[06/06] patch #1444 - implement setting_log() / setting_error() functions

attached is the entire series as one patch

(file #7937)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Mon 25 Jan 2010 05:27:32 PM UTC, comment #3:

Updated Settings Patch series:

[--/--] bug #13869 - (will not be applied)
[01/07] bug #13871 - add settting action callback function
[02/07] bug #13873 - save game settings in game.ruleset
[03/07] patch #1198 - show changed game settings after reset and rulesetdir
[04/07] patch #1298 - Documentation of the setting changes in the ruleset
[05/07] patch #1200 - game settings can be locked by the ruleset
[06/07] patch #1300 - add 'show locked' command
[07/07] patch #1284 - update reset command (WIP)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Sat 10 Oct 2009 10:44:08 PM UTC, comment #2:

a updated version of the settings patch series is available:

[01/10] bug #13867 - (updated version by pepeto)
[02/10] bug #13868 - use an union in the struct setting
[03/10] bug #13869 - simplify validation functions
[--/--] bug #13870 - (removed)
[04/10] bug #13871 - add settting action callback function
[--/--] bug #13872 - (included in bug #13867)
[05/10] bug #13873 - save game settings in game.ruleset
[06/10] patch #1198 - show changed game settings after reset and rulesetdir
[07/10] patch #1298 - Documentation of the setting changes in the ruleset
[08/10] patch #1200 - game settings can be locked by the ruleset
[--/--] patch #1299 - (merged with patch #1200)
[09/10] patch #1300 - add 'show locked' command
[10/10] patch #1284 - update reset command

the attached patch is a 'all-in-one' version

(file #6953)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Mon 14 Sep 2009 05:28:55 PM UTC, comment #1:

I renamed this as metaticket since your comment includes links to all actual patches.

Marko Lindqvist <cazfi>
Project Administrator
Sun 13 Sep 2009 08:58:18 PM UTC, original submission:

this patch includes all 13 parts of the settings patch series

[01/13] bug #13867 - get game settings via wrapper functions
[02/13] bug #13868 - use an union in the struct setting
[03/13] bug #13869 - simplify validation functions
[04/13] bug #13870 - extra functions to check and update settings
[05/13] bug #13871 - add settting action callback function
[06/13] bug #13872 - move sset_is_to_client() to settings.c
[07/13] bug #13873 - save game settings in game.ruleset
[08/13] patch #1200 - game settings can be locked by the ruleset
[09/13] patch #1198 - show changed game settings after reset and rulesetdir
[10/13] patch #1298 - Documentation of the setting changes in the ruleset
[11/13] patch #1299 - <setting>.lock only allowed if the settings is defined for the ruleset
[12/13] patch #1300 - add 'show locked' command
[13/13] patch #1284 - update reset command

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #7937:  20100205-settings.patch.bz2 added by syntron (12kB - application/x-bzip2)
file #6953:  settings20091010.diff.gz added by syntron (28kB - application/x-gzip)
file #6694:  settings.diff added by syntron (122kB - text/x-diff)

 

Depends on the following items
bugs [patch 01/07] get game settings via wrapper functions (bug #13867, Fixed)
bugs [patch 02/07] use an union in the struct setting (bug #13868, Fixed)
bugs [patch 04/07] extra functions to check and update settings (bug #13870, Wont Fix)
bugs [patch 05/07] add setting action callback function (bug #13871, Fixed)
bugs [patch 06/07] move sset_is_to_client() to settings.c (bug #13872, Fixed)
bugs [patch 07/07] load game settings from ruleset file (bug #13873, Fixed)
patch show changed game settings after reset and rulesetdir (patch #1198, Done)
patch game settings can be locked by the ruleset (patch #1200, Done)
patch update reset command (patch #1284, Done)
patch Documentation of the setting changes in the ruleset (patch #1298, Done)
patch <setting>.lock only allowed if the settings is defined for the ruleset (patch #1299, Done)
patch add 'show locked' command (patch #1300, Done)
patch Send is_changeable instead of sclass for server settings (patch #1427, Done)
patch Send the settable_options_control packet only once (patch #1428, Done)
patch show changed settings only one time if a comand file is read (patch #1437, Done)
patch implement setting_log() / setting_error() functions (patch #1444, Done)
patch add information to the reject_msg within settings.c (patch #1460, Done)
patch fix duplicated check for min/max integer value (patch #1461, Done)
bugs Error messages when loading a savegame (bug #15406, Fixed)
patch New client options interface (patch #1475, Done)
patch ---- Private ---- (patch #1484, Done)
patch Merge client and server options GUI (patch #1485, Done)
patch Merge client and server options GUI (patch #1486, Done)
patch Merge client and server options GUI (patch #1487, Done)
patch Option set (patch #1491, Done)
patch Add error message for not supported option types (patch #1575, Done)
patch Add combo box widget type (patch #1576, Done)
patch Add video mode option type (patch #1584, Done)
patch Add color option type (patch #1623, Done)
patch Server setting packet definitions (patch #1624, Done)
patch Implement color option type in sdl client (patch #1631, Postponed)
patch Implement color option type in xaw client (patch #1632, None)
patch Add 'enum' option type (patch #1633, Done)
patch Implement 'enum' option type (patch #1634, Done)
patch Implement 'enum' option type (patch #1635, Done)
patch Implement 'enum' option type in xaw client (patch #1636, None)
patch Implement 'enum' server setting type (patch #1637, Done)
patch update server setting type boolean (patch #1726, Done)
patch Implement bitwise client option type (patch #1954, Done)
patch Implement bitwise server option type (patch #1955, Done)
patch Implement bitwise option type in gtk client (patch #1956, Done)
patch Implement bitwise option type in sdl client (patch #1957, Postponed)
patch Implement bitwise option type in xaw client (patch #1958, None)
patch Make 'topology', 'killcitizen' & 'airliftstyle' bitwise options (patch #1959, Done)
patch Secfile utility to save custom enum values (patch #1982, Done)
patch Cleanup for 'enum' options (patch #1983, Done)
bugs Miscellaneous cleanup in settings (bug #16761, Fixed)
patch Separate saved and user-visible strings for client enum/bitwise options (patch #1989, Done)
bugs Loading multiplayer ruleset produce an error message (bug #16931, Fixed)
bugs 'enum' server setting loading failures are set to 0 (bug #16932, Fixed)
patch Make 'compresstype' an enumerator server setting (patch #2090, Done)
patch Server setting 'mapsize' cleanup (patch #2091, Done)
patch Settings sent to the metaserver cleanup (patch #2092, Done)
patch Server setting 'generator' cleanup (patch #2093, Done)
patch Server setting 'startpos' cleanup (patch #2094, Done)
patch Server setting 'borders' cleanup (patch #2095, Done)
patch Server setting 'diplomacy' cleanup (patch #2096, Done)
patch Server setting 'citynames' cleanup (patch #2097, Done)
patch Server setting 'barbarians' cleanup (patch #2098, Done)
bugs 'topology' doesn't match anymore numbers (bug #16956, Fixed)
bugs Server boolean options cannot be correctly set (bug #17065, Fixed)

Digest:
   bug dependencies, patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by dmarks (Updated the item)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by syntron (Submitted the item)

    •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 25 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 28 Oct 2011 09:31:00 PM UTCjtnPlanned Release=>2.3.0
    Fri 28 Oct 2011 09:29:53 PM UTCjtnStatusNone=>Done
      Open/ClosedOpen=>Closed
    Fri 28 Oct 2011 09:26:25 PM UTCjtnStatusIn Progress=>None
      Planned Release2.4.0=>
    Fri 28 Oct 2011 09:00:29 PM UTCjtnStatusPostponed=>In Progress
      Assigned toNone=>syntron
      Planned Release=>2.4.0
    Fri 28 Oct 2011 08:59:57 PM UTCsyntronStatusIn Progress=>Postponed
      Assigned tosyntron=>None
      Planned Release2.4.0=>
    Thu 27 Oct 2011 09:57:46 PM UTCcazfiAssigned toNone=>syntron
    Thu 09 Jun 2011 11:54:12 AM UTCcazfiPlanned Release2.3.0=>2.4.0
    Fri 31 Dec 2010 04:10:00 PM UTCpepetoAssigned topepeto=>None
    Fri 12 Nov 2010 10:26:34 PM UTCpepetoDependencies-=>Depends on bugs #17065
    Tue 26 Oct 2010 11:06:46 AM UTCpepetoDependencies-=>Depends on bugs #16956
    Sat 23 Oct 2010 07:16:55 PM UTCpepetoDependencies-=>Depends on bugs #16932
      Dependencies-=>Depends on patch #2098
      Dependencies-=>Depends on patch #2097
      Dependencies-=>Depends on patch #2096
      Dependencies-=>Depends on patch #2095
      Dependencies-=>Depends on patch #2094
      Dependencies-=>Depends on patch #2093
      Dependencies-=>Depends on patch #2092
      Dependencies-=>Depends on patch #2091
    Show feedback again

    Back to the top


    Copyright (C) 2004-2006, the Gna! people. Posted items are owned by whoever posted them.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.

    Powered by Savane 3.1-cleanup