patchFreeciv - Patches: patch #1390, Help: units/combat help...

Show feedback again

patch #1390: Help: units/combat help improvements

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Mon Dec 14 02:29:20 2009  
Category: docsPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: pepeto <pepeto>Open/Closed: Closed
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Mon Dec 21 16:12:44 2009, SVN revision 16506:

Miscellaneous improvements to help for units and combat.

Patch by Jacob Nevins (jtn)

See gna patch #1390

(Browse SVN revision 16506)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Dec 21 16:12:39 2009, SVN revision 16505:

Miscellaneous improvements to help for units and combat.

Patch by Jacob Nevins (jtn)

See gna patch #1390

(Browse SVN revision 16505)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Dec 14 02:29:20 2009, original submission:

Miscellaneous improvements to help for units and combat, including:

  • Rewrite introductory unit help: remove most text describing unit classes, as it doesn't apply to all rulesets and is now fairly well covered by autogenerated help; instead, describe upkeep, movement points, and the veteran system (much of the material is from wiki).
  • Fix up Combat help to match reality (default ruleset).
  • Completely revamp and expand Diplomat and Spy help, from wiki material.
  • Describe nuclear winter in help for Nuclear units.
  • Remove claims that Carriers can't attack.
  • Reinstate help for F_TRIREME (for civ1/2 rulesets).
  • Note existence of diplomat defence (including F_SUPERSPY).
  • Don't display "will be built as veteran" text for units that can't be built (e.g., Barbarian Leader), or "may be promoted" text for units that never survive any engagement (e.g., missiles).
  • Move repeated text from Settler/Worker descriptions to Terrain Alterations help.
  • Note which unit classes aren't subject to ZOC (air, sea).
  • Unit-class-ify fortify ability, and remove redundant pillage text.
  • A few grammar/punctuation tweaks.

Some remaining rough edges (shouldn't block commit, it's still better than it was IMO):

  • Autogenerated help for bases hardcoded for rulesets like the default one. Fixing this will require navigating the effects system, in much the same way as will render much of my patch #1384 unnecessary. I have some ideas, but don't know when I'll get round to them.
  • Hardcoded references to Barracks, Coastal Defense etc. Same comment.
Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #7498:  help-units.diff added by jtn (52kB - text/x-patch - Units and combat help improvements, against S2_2 r16490)


Depends on the following items: None found

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Jan 8 12:15:33 2010jtnDependencies-=>patch #1401 is dependent
    Mon Dec 21 16:13:14 2009pepetoStatusReady For Test=>Done
    Sat Dec 19 22:18:53 2009pepetoStatusNone=>Ready For Test
      Assigned toNone=>pepeto
    Mon Dec 14 02:29:21 2009jtnAttached File-=>Added help-units.diff, #7498
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup