patchFreeciv - Patches: patch #1864, Make many territory claiming bases...

 
 
Show feedback again

patch #1864: Make many territory claiming bases possible on a same tile

Submitted by:  pepeto <pepeto>
Submitted on:  Tue 17 Aug 2010 01:55:25 PM UTC  
 
Category: rulesetsPriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Aug 2010 03:23:12 PM UTC, comment #2:

> I don't understand your changes to tile_border_source_strength()


I was thinking about custom rulesets defining a base with a big border square distance. In this case, tile_border_source_radius() would return the base border square distance instead of the city which would be smaller. To avoid players to make both cities and bases to steal territory to the enemy, then tile_border_source_strength() returns the city strength (which is really superior) only in its own border radius, else it returns the small strength of the base. It is like a double claiming between cities and bases.

For example, let say there is a city (with border radius of 3, strength 5) and a base (radius 5, but strength 1 like all bases). Then in a radius of 4 or 5, the strength would be of 1. In a radius of 3, the strength would be 5.

> Comment there at least needs rewording as "this place" seems
> to refer in location not visible to this function at all (this
> border source tile, and "this place" probably means place
> where border is applied)


Yes it is. It would probably be clearer.

pepeto <pepeto>
Project Member
Tue 17 Aug 2010 02:56:25 PM UTC, comment #1:

I don't understand your changes to tile_border_source_strength(). Comment there at least needs rewording as "this place" seems to refer in location not visible to this function at all (this border source tile, and "this place" probably means place where border is applied)

Marko Lindqvist <cazfi>
Project Administrator
Tue 17 Aug 2010 01:55:25 PM UTC, original submission:

I have thought about it, after the comment by Marko in bug #16465.

I have some problems to test for the moment, notably since I cannot do pillage. I am not totally sure about how works create_base() in server/maphand.c.

pepeto <pepeto>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by jtn (Interacts with my plans for bug #16385)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 18 Jun 2012 01:12:57 AM UTCjtnPlanned Release2.4.0=>
    Wed 27 Oct 2010 01:47:02 PM UTCpepetoAssigned topepeto=>None
      Planned Release2.3.0=>2.4.0
    Sun 05 Sep 2010 12:29:22 PM UTCjtnCarbon-Copy-=>Added jtn
    Sat 04 Sep 2010 01:23:10 PM UTCpepetoStatusReady For Test=>In Progress
      Assigned toNone=>pepeto
    Tue 17 Aug 2010 01:55:25 PM UTCpepetoAttached File-=>Added trunk_territory_claiming_bases.diff, #9897
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup