patchFreeciv - Patches: patch #2121, [delegation02] add delegation...

 
 
Show feedback again

patch #2121: [delegation02] add delegation (especially for longturn)

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Fri 29 Oct 2010 08:15:41 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Matthias Pfafferodt <syntron>Open/Closed: Closed
Planned Release: 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 01 Jul 2012 11:54:40 AM UTC, comment #6:

Can someone point me at the original discussion / implementation of the delegate feature and its purpose (presumably for Longturn)? I think I understand the basics, but I'd like to work out what it should do in some corner cases that our version doesn't currently handle.

(If no documentation, I'll post my queries in a new ticket.)

Jacob Nevins <jtn>
Project Administrator
Fri 14 Jan 2011 10:29:20 PM UTC, SVN revision 18942:

add delegation

  • delegate your control to another username
  • new command: /delegate
  • if a connection is detached restore the player state

(new wrapper function connection_close_server())

see gna patch #2121

(Browse SVN revision 18942)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Wed 05 Jan 2011 06:36:55 PM UTC, comment #4:

changes 20101230:

  • rewrite much of the code
  • move take/restore part to their own functions in connecthand.c
  • if a connection is detached restore player state (new function connection_close_server())

changes 20110105:

  • rebased directly to trunk (does not need fcdb patches)

(file #11704)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Thu 23 Dec 2010 12:43:53 PM UTC, comment #3:

new version of the patch:

  • no dependency on any database
  • save delegation
  • bugs:

- taking a player from an observer works but going back is not possible
- more?

please test!

(file #11661)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Sat 30 Oct 2010 10:01:04 AM UTC, comment #2:

> Why does it requires auth support enabled?


Because I did use the longturn usage as example and guideline?

Yea, it could be done entirely in the server without an external database ... I will have to think about this. Thanks for the comment.

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 29 Oct 2010 11:06:00 PM UTC, comment #1:

Why does it requires auth support enabled?

pepeto <pepeto>
Project Member
Fri 29 Oct 2010 08:15:41 PM UTC, original submission:
  • new command 'delegate'
  • needs auth/luasql

limit commands in delegation mode?

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Digest:
   patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by syntron (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 14 Jan 2011 10:30:45 PM UTCsyntronStatusIn Progress=>Done
      Open/ClosedOpen=>Closed
    Fri 14 Jan 2011 12:11:28 PM UTCsyntronDependencies-=>patch #1494 is dependent
    Wed 05 Jan 2011 06:43:46 PM UTCsyntronDependencies-=>Depends on patch #2276
      Dependencies-=>Depends on patch #2275
      Dependencies-=>Depends on patch #2273
      Dependencies-=>Depends on patch #2272
    Wed 05 Jan 2011 06:36:55 PM UTCsyntronAttached File-=>Added 20110105-delegation02-add-delegation.patch, #11704
      Summaryadd delegation (especially for longturn)=>[delegation02] add delegation (especially for longturn)
    Thu 23 Dec 2010 12:44:07 PM UTCsyntronSummary[fcdb] add delegation (especially for longturn)=>add delegation (especially for longturn)
    Thu 23 Dec 2010 12:43:53 PM UTCsyntronAttached File-=>Added 20101223-add-delegation.patch, #11661
    Fri 29 Oct 2010 08:15:41 PM UTCsyntronAttached File-=>Added 20101029-06-trunk-add-delegation.patch, #10989
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup