patchFreeciv - Patches: patch #2443, Qt-client: Attach canvas to...

Show feedback again

patch #2443: Qt-client: Attach canvas to mapview widget

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 30 Jan 2011 11:47:48 PM UTC  
Category: client-qtPriority: 5 - Normal
Status: Wont DoPrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Mon 25 Mar 2013 07:58:09 AM UTC, comment #2:

Not applicable any more.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 05 Feb 2011 02:38:47 AM UTC, comment #1:

I really have to rethink Qt-client canvas implementation. There's conflict between client common code philosophy and QtGraphicsScene philosophy that makes it hard to fit them together.
Client common code assumes that one can simply draw over items on canvas and their gone. In QtGraphicsScene objects remain even if they are hidden. As client common code never explicitly removes anything, and it would be very hard to implement such removal, there's just more and more items on QtGraphicsScene after each redraw.

So, patches related to Qt-client mapview & other canvases are on hold.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 30 Jan 2011 11:47:48 PM UTC, original submission:

Attach canvas to mapview widget so that drawing to canvas will be visible on screen.
This works very differently from other clients, and is probably sub-optimal. I'm ready to go forward with this nevertheless. In this early phase priority is not to get details perfectly, but to get Qt-client to usable state. We can refactor and improve later.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #12182:  QtCanvasToMapview.diff added by cazfi (8kB - text/x-diff)


Depends on the following items: None found

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 25 Mar 2013 07:58:09 AM UTCcazfiStatusIn Progress=>Wont Do
      Assigned toNone=>cazfi
    Thu 27 Oct 2011 09:58:56 PM UTCcazfiPlanned Release2.4.0=>2.5.0
    Sat 05 Feb 2011 02:38:47 AM UTCcazfiStatusReady For Test=>In Progress
    Wed 02 Feb 2011 03:11:15 AM UTCcazfiDependencies-=>patch #2454 is dependent
    Sun 30 Jan 2011 11:47:49 PM UTCcazfiAttached File-=>Added QtCanvasToMapview.diff, #12182
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup