patchFreeciv - Patches: patch #2477, [transport09] use pointer for...

 
 
Show feedback again

patch #2477: [transport09] use pointer for transported units (server/common)

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Fri 04 Feb 2011 04:44:01 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Matthias Pfafferodt <syntron>Open/Closed: Closed
Planned Release: 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 30 Oct 2011 08:09:17 PM UTC, SVN revision 20387:

use pointer for transported units (server/common)

  • add unit->transporter (transporter for the unit)
  • add a list of transported units (unit->transporting)
  • accessor functions:

- bool unit_transport_load(pcargo, ptrans)
- bool unit_transport_unload(pcargo, ptrans)
- bool unit_transported(pcargo)
- struct unit *unit_transport_get(pcargo)
- struct unit_list *unit_transport_cargo(ptrans)

see gna patch #2477

(Browse SVN revision 20387)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Tue 25 Oct 2011 08:50:17 PM UTC, comment #3:

rebased patch

changes 20111020:

  • fix comment
  • fix allied units on transporters

(file #14250)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 19 Aug 2011 10:39:40 PM UTC, comment #2:

rebased patch; changes:

  • move cleanup of unit_move() to another patch
  • add unit_transported() function as simplified unit_transport_get()

(file #13922)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 18 Feb 2011 02:17:24 PM UTC, comment #1:

updated patch:

  • autogame test (first move transported units and then the transporter)
  • fix wrong '==' in advmilitary.c; should be '='
  • cleanup a check in aiunit.c

there are still differences in autogames; this needs further investigations ...

(file #12483)

Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.
Fri 04 Feb 2011 04:44:01 PM UTC, original submission:
  • add unit->transporter (transporter for the unit)
  • add a list of transported units (unit->transporting)
  • accessor functions:

- bool unit_transport_load(pcargo, ptrans)
- bool unit_transport_unload(pcargo, ptrans)
- struct unit *unit_transport_get(pcargo)
- struct unit_list *unit_transport_cargo(ptrans)

  • move moving of transported units into unit_move_transported() which is called recursivly
  • cleanup the function unit_move()
Matthias Pfafferodt <syntron>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by syntron (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 30 Oct 2011 08:09:56 PM UTCsyntronStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Tue 25 Oct 2011 08:50:17 PM UTCsyntronAttached File-=>Added 0001-use-pointer-for-transported-units-server-common.patch, #14250
      Assigned toNone=>syntron
    Fri 19 Aug 2011 10:39:40 PM UTCsyntronAttached File-=>Added 20110819-transport01-use-pointer-for-transported-units-server-common.patch, #13922
    Fri 18 Feb 2011 02:17:24 PM UTCsyntronAttached File-=>Added 20110218-use-pointer-for-transported-units-server-common.patch, #12483
    Fri 04 Feb 2011 04:52:17 PM UTCsyntronDependencies-=>patch #2270 is dependent
    Fri 04 Feb 2011 04:44:01 PM UTCsyntronAttached File-=>Added 20110204-transport09-use-pointer-for-transported-units-server-common.patch.bz2, #12271
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup