patchFreeciv - Patches: patch #2520, [metaticket] common lua interface

Show feedback again

patch #2520: [metaticket] common lua interface

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Fri Feb 11 17:20:30 2011  
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Tue Aug 9 22:36:35 2011, comment #8:

updated patch series; a summary of the old/new functions and structure can be found on the wiki page mentioned in comment #7

Matthias Pfafferodt <syntron>
Project Member
Sun Aug 7 20:32:56 2011, comment #7:

I have created a wiki page which shows all changes:

I will resend the patches after the testgame is ready.

Matthias Pfafferodt <syntron>
Project Member
Thu Jun 9 20:48:51 2011, comment #6:

You can commit the patch. Due to other changes I have to rebase this patch. Another function to check for is OK. If all goes as planned I have a good internet connection at the start of the next month.

Matthias Pfafferodt <syntron>
Project Member
Thu Jun 9 11:03:29 2011, comment #5:

Any plans to proceed with this soonish?

Just wondering what to do with patch #2672 (should we avoid messing with scripting stuff until this series has gone in?)

Marko Lindqvist <cazfi>
Project Administrator
Wed Feb 23 17:14:58 2011, comment #4:

At the moment I have to prepare the defence of my PhD thesis and start my new job. Thus, I will not finish this patch till the end of march.

I think you can commit these patches. I will adapt the patch series to the changes. First priority will be the test script so that the basic changes (patch #2513 and patch #2514) can be committed.

Matthias Pfafferodt <syntron>
Project Member
Wed Feb 23 16:07:01 2011, comment #3:

Should I refrain from adding anything to scripting interface until you have finished your refactoring? Would it be acceptable to commit at least existing patch #2548 and patch #2552 ?

Marko Lindqvist <cazfi>
Project Administrator
Tue Feb 22 13:38:05 2011, comment #2:

> Description of this ticket could be a bit more verbose :-)

Sorry, I do use this only as helper to find all the dependend tickets ;-) So here is a summary of the history and a current status:

In patch #2143 the possibility of an lua script AI is discussed. I started to work on it. This resulted in some problems. To solve them I did a rework of the script module:

  • patch #2513 (only moving of existing files) and patch #2514 (changes and new files) are the basic parts. The directory ./server/scripting is splitted in a common part (./common/scriptcore) and the server part. All functions which do not need data only available in the server are moved. Also the core of the lua script module is defined there. It includes the signal submodule as well as the functions submodule (lua functions called from the c code; see freeciv database).
  • the other patches define the client lua console - as lua was now also available for the client it was something easy to do (easier than a lua AI!)
  • not posted are some cleanups to this interface and lua functions to print all variables / functions, definition of constants in lua and work for the lua AI.
  • The state of the lua AI is 'not working' ... As it calls the default AI from the lua code, my first test resulted in a lot of errors. There was no clear line between both AIs. But I could start the server with this AI module!
Matthias Pfafferodt <syntron>
Project Member
Tue Feb 22 11:27:43 2011, comment #1:

Description of this ticket could be a bit more verbose :-)

Marko Lindqvist <cazfi>
Project Administrator
Fri Feb 11 17:20:30 2011, original submission:
Matthias Pfafferodt <syntron>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items

   patch dependencies.

   patch dependencies.


Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by syntron (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 25 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Sep 27 05:17:41 2016cazfiStatusIn Progress=>Done
    Sun Aug 4 19:27:03 2013cazfiPlanned Release2.4.0=>
    Thu Sep 22 19:37:57 2011syntronDependencies-=>Depends on patch #2968
      Dependencies-=>Depends on patch #2955
    Thu Sep 22 19:28:03 2011syntronDependencies-=>patch #2969 is dependent
    Thu Sep 22 18:40:26 2011syntronDependencies-=>patch #2965 is dependent
    Tue Aug 9 22:35:38 2011syntronDependencies-=>Depends on patch #2884
      Dependencies-=>Depends on patch #2883
      Dependencies-=>Depends on patch #2882
      Dependencies-=>Depends on patch #2881
      Dependencies-=>Depends on patch #2880
    Tue Aug 9 22:23:58 2011syntronDependencies-=>Depends on patch #2879
      Dependencies-=>Depends on patch #2878
      Dependencies-=>Depends on patch #2877
      Dependencies-=>Depends on patch #2876
      Dependencies-=>Depends on patch #2875
      Dependencies-=>Depends on patch #2874
      Dependencies-=>Depends on patch #2873
      Dependencies-=>Depends on patch #2872
      Dependencies-=>Depends on patch #2871
      Dependencies-=>Depends on patch #2870
      Dependencies-=>Depends on patch #2869
    Tue Aug 9 22:08:37 2011syntronDependencies-=>patch #2869 is dependent
    Fri Feb 11 17:22:40 2011syntronDependencies-=>patch #2143 is dependent
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup