patchFreeciv - Patches: patch #2747, Option to use system lua

 
 
Show feedback again

patch #2747: Option to use system lua

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 23 Jun 2011 09:09:00 PM UTC  
 
Category: bootstrapPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Jul 2011 05:05:44 AM UTC, SVN revision 19903:

Added configure option --enable-sys-lua to use lua from system instead
of one included in freeciv tree.

See gna patch #2747

(Browse SVN revision 19903)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 03 Jul 2011 09:32:48 PM UTC, comment #1:

- Updated against current svn

(file #13457)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 23 Jun 2011 09:09:00 PM UTC, original submission:

Over the years there has been numerous discussion about possibility to use lua from host system instead of one that freeciv provides in its own source tree.
Lat time I took part in such discussion we were still using toluaxx and a bit everything in our scripting system was unstable. Back then my opinion was that we simply have to get things working reliably with the exact lua we ship before we start supporting any variation adding another variable to make problem debugging harder.
I think we have since well reached the point in quality where exact revision of lua no longer matters as long as api has not changed.
Debian at least ships freeciv with modification, much uglier than this patch, that makes it to use system lua. So even if we would insist in upstream that only specific lua version can be reliably supported, final end user would still get problems of using system lua.
Thus, attached patch adds configure option to use system lua instead of one in freeciv tree. Default is still to use in-tree lua. With good reasoning I could be convinced that default should be using system lua, but for now we have to have at least option to use in-tree lua, and thus need to maintain that in-tree copy remains.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13457:  SysLua_2747-2.diff added by cazfi (3kB - text/plain)
file #13325:  SysLua.diff added by cazfi (3kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Jul 2011 05:05:55 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 03 Jul 2011 09:32:48 PM UTCcazfiAttached File-=>Added SysLua_2747-2.diff, #13457
    Thu 23 Jun 2011 09:09:00 PM UTCcazfiAttached File-=>Added SysLua.diff, #13325
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup