patchFreeciv - Patches: patch #2789, 16bit packet type

 
 
Show feedback again

patch #2789: 16bit packet type

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 11 Jul 2011 10:16:20 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 02 Nov 2011 06:57:16 AM UTC, SVN revision 20420:

Increased size of network packet type field to 16 bit.

See gna patch #2789

(Browse SVN revision 20420)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 27 Oct 2011 06:54:29 PM UTC, comment #1:

- Updated against current svn
- Packet type number sanity check only in debug builds

(file #14293)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 11 Jul 2011 10:16:20 PM UTC, original submission:

We discussed already when editor was in development that we may eventually run out of unique packet numbers. We still have some space left, and there's many ways to reuse packet numbers, but just to avoid any uglier solutions I'd like to increase packet number space before this becomes a real problem. Attached patch makes packet type 16 bit value (currently 8 bit). This is still not very much tested, and anyway I'd like to commit it from the beginning of the new cycle (soon after S2_4 branching) rather than
late in cycle that has used 8 bit types so far.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13525:  16BitPacketType.diff added by cazfi (5kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 02 Nov 2011 06:57:35 AM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 27 Oct 2011 06:54:29 PM UTCcazfiAttached File-=>Added 16BitPacketType_2789-2.diff, #14293
    Mon 11 Jul 2011 10:16:20 PM UTCcazfiAttached File-=>Added 16BitPacketType.diff, #13525
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup