|
Fri 29 Jul 2011 06:02:20 AM UTC, SVN revision 20032:
Fixed freeciv-modpack initialization.
Patch by Christian Prochaska and myself
See gna patch #2812
(Browse SVN revision 20032) |
Wed 27 Jul 2011 08:22:19 PM UTC, SVN revision 20014:
Get gthread compilation flags with PKG_CHECK_MODULES. I assume this to
fix compilation problem reported by Jordi Negrevernis i Font
See gna patch #2812
(Browse SVN revision 20014) |
Wed 27 Jul 2011 08:19:36 PM UTC, comment #10:
Patch for S2_3 that uses PKG_CHECK_MODULES() there too. Applies on top of already committed patch.
Compiles for both linux and MinGW, works on linux (I cannot test Windows)
Jordi Negrevernis i Font reports that currently S2_3 does not compile for him and I assume this to fix it. So committing this immediately as compilation fix.
(file #13680)
|
Thu 21 Jul 2011 03:50:44 PM UTC, comment #9:
This at least compiles for both linux and MinGW.
(file #13617)
|
Thu 21 Jul 2011 03:15:18 PM UTC, comment #8:
My turn to steal this ticket in order to implement configure stuff with proper PKG_CHECK_MODULES()
|
Wed 20 Jul 2011 09:02:15 PM UTC, comment #7:
I have not (yet) looked the patch, but manually writing something like "-lgthread2.0" sounds suspicious anyway. You should probably be using pkg-config.
|
Wed 20 Jul 2011 08:56:59 PM UTC, comment #6:
> I can fix the Gtk2 case, but not the Gtk3 case: I don't know
> what to put in MP_gtk_LIBS where we have "-lgthread2.0" in Gtk2,
> if anything. Any ideas?
gthreads are part of glib, not gtk, so it doesn't matter if we are building gtk2- or gtk3-version. AFAIK you should use same "-lgthread2.0".
|
Wed 20 Jul 2011 08:21:37 PM UTC, comment #5:
Thanks for the patch. Stealing and quick committing to S2_3 for 2.3.0.
(Justification for breaking code freeze: this takes freeciv-modpack.exe from useless to useful, and looks to have a low risk of breaking anything else.)
However, the configure.ac bit of the patch doesn't apply cleanly to trunk, so the ticket stays open. I can fix the Gtk2 case, but not the Gtk3 case: I don't know what to put in MP_gtk_LIBS where we have "-lgthread2.0" in Gtk2, if anything. Any ideas?
|
Wed 20 Jul 2011 08:06:44 PM UTC, SVN revision 19986:
More initialization fixes for freeciv-modpack, and add an explicit dependency
on libgthread on Windows. After this, freeciv-modpack can actually download
modpacks on Windows.
Reported and patched by Christian Prochaska (cproc@gna).
See gna patch #2812.
(Browse SVN revision 19986) |
Mon 18 Jul 2011 10:06:13 PM UTC, comment #3:
NB, the patch attached here also includes the patch for bug #18354.
|
Sun 17 Jul 2011 07:08:14 PM UTC, comment #2:
(Oh, and freeciv-modpack launched fine from the start menu (thanks). Suggest it's called "Freeciv modpack installer" rather than just "Freeciv Modpack.)
|
Sun 17 Jul 2011 07:06:41 PM UTC, comment #1:
I tried this build on my Windows 7 Home Premium installation, and it worked apparently fine[*] for me too.
[*] Not everything went smoothly, but I think these are separate problems:
- Downloading cazfi's Amplio modpack, it was corrupted, but checking back on Linux the corruption happens there too. See bug #18369.
- Downloading the currently advertised "ancients" modpack, there was no corruption, but the first time I tried to start a client (with spawned server) afterwards, the server crashed. I couldn't reproduce this afterward. (I've never used the Ancients modpack before.) Since the files were fine, I think this is entirely separate.
|
Sun 17 Jul 2011 03:14:57 AM UTC, original submission:
$subject + add libgthread dependency on Windows, where it is not already a dependency of GTK+ as on Linux.
Modpack downloading seems to work now on Windows. Here's an S2_3 Windows package for testing: http://download.gna.org/freeciv/packages/windows/testing/Freeciv-S2_3-2011-07-17-win32-gtk2-setup.exe
|
Related Recipes:
Freeciv - Patches: patch #2812, Fix modpack initialization