patchFreeciv - Patches: patch #2831, Alternative to gui-qt function...

Show feedback again

patch #2831: Alternative to gui-qt function pointer layer

Submitted by:  Christian Prochaska <cproc>
Submitted on:  Sun Jul 24 20:57:15 2011  
Category: client-qtPriority: 5 - Normal
Status: Wont DoPrivacy: Public
Assigned to: mir3x <mir3x>Open/Closed: Closed
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Jun 22 12:13:35 2013, comment #5:

Not applicable any more.

mir3x <mir3x>
Project MemberIn charge of this item.
Thu Aug 18 23:26:00 2011, comment #4:

Assuming that there are no problems realizing it, the modular approach sounds more elegant.

David Lowe <doctorjlowe>
Mon Aug 15 19:55:41 2011, comment #3:

Whta's your plan with this patch? I'll make it clear in case you misunderstood my previous comment: I have no strong feelings either way about this patch; if nobody else has anything to say, feel free to commit or not to commit.

Marko Lindqvist <cazfi>
Project Administrator
Sun Jul 24 21:22:10 2011, comment #2:

Updated patch. Some of the 'extern "C"'s in the previous patch were actually not necessary.

(file #13656)

Christian Prochaska <cproc>
Project Administrator
Sun Jul 24 21:22:02 2011, comment #1:

Well, changing that probably makes sense, though I have been toying with opposite idea; to start using function pointer layer for all guis. That would allow for example design where we would hjave just one client program to which different guis are loaded as modules.

Marko Lindqvist <cazfi>
Project Administrator
Sun Jul 24 20:57:15 2011, original submission:

The attached patch defines the GUI functions called from common code as 'extern "C"' to avoid the naming problems. This seems to work as well as using a function pointer layer.

Christian Prochaska <cproc>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #13656:  gui_qt_names_2.diff added by cproc (88kB - text/x-patch)
file #13653:  gui-qt_names.diff added by cproc (88kB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by mir3x (Posted a comment)
  • -unavailable- added by doctorjlowe (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by cproc (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Jun 22 12:13:35 2013mir3xStatusNone=>Wont Do
      Assigned toNone=>mir3x
    Sun Jul 24 21:22:10 2011cprocAttached File-=>Added gui_qt_names_2.diff, #13656
    Sun Jul 24 20:57:15 2011cprocAttached File-=>Added gui-qt_names.diff, #13653
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup