patchFreeciv - Patches: patch #3007, City center roads subject to...

 
 
Show feedback again

patch #3007: City center roads subject to terrain restrictions

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 02 Nov 2011 10:02:41 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 08 Nov 2011 11:18:59 PM UTC, SVN revision 20515:

Made granting of roads to city centers subject to terrain restrictions.

See gna patch #3007

(Browse SVN revision 20515)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 02 Nov 2011 10:02:41 PM UTC, original submission:

This patch changes rule that city center always has road to that city center roads are subject to terrain restrictions. If terrain cannot have road, city center will have no road. If city is on river tile and player doesn't know bridge building, city center will not gain road (but existing one is not removed if city is conquered by player who lacks required technology)

Testing has been minimal so far. I would be quite surprised if there will be no iterations of this patch before committing. I set status to "Ready For Test" instead of "In Progress" regardless, to keep tthe option that I'll commit this one if it passes my tests.

This patch may seem like something that changes one arguably wrong rule to another one that others may consider wrong, and does so by making code more complex and bugprone. I should mention that having existence of roads to always respect terrain restrictions makes some future patches much more simpler, cleaner, and less bugprone.

Cities on river tiles not having roads in the beginning of the game can make huge difference. That needs a lot of testing, and possibly some other changes to balance it, or even just new, more compatible with future patches, implementation of the feature that cities on river tiles get road even when bridge building is not known.

While testing this patch I noticed that roads in cities were not upgraded when I granted technologies from editor. That may be bug in existing code (=stable branches) meaning city center roads are not upgradet when one gives Railroad-technology in editor. This should be checked, and separate bug ticket opened for it if it indeed is buggy.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14391:  CityCenterRoadsB.diff added by cazfi (10kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 08 Nov 2011 11:19:13 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 02 Nov 2011 10:02:41 PM UTCcazfiAttached File-=>Added CityCenterRoadsB.diff, #14391
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup