patchFreeciv - Patches: patch #3137, Cumulative Barracks and Sun Tzu...

 
 
Show feedback again

patch #3137: Cumulative Barracks and Sun Tzu documentation

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 16 Feb 2012 06:45:06 PM UTC  
 
Category: docsPriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 18 Feb 2012 09:12:38 PM UTC, comment #3:

Patch #3062 is the one that would make VeteranBuild effect value to be considered integer instead of boolean.

AI considering this to be true also in stable branches raised as bug #19466.

Marko Lindqvist <cazfi>
Project Administrator
Sat 18 Feb 2012 12:49:03 PM UTC, comment #2:

> do_make_unit_veteran(), which still returns a boolean result.


Indeed, it seems to have return type 'int', but returns either TRUE or FALSE. This inconsistency could be even consider a bug.

> I can see places where the AI behaves as though it is true, for
> instance dai_choose_defender_versus().


That was probably the place that used to crash with civ2 ruleset (before my fixes) and where I got the impression that VeteranBuild effect is now considered int and not bool (I remember someone working on patch to make it so, so I just assumed that it has been changed)

Marko Lindqvist <cazfi>
Project Administrator
Sat 18 Feb 2012 11:04:36 AM UTC, comment #1:

Is this actually true?
I can't see where in the code this would happen -- the actual unit creation is based on do_make_unit_veteran(), which still returns a boolean result.
And I couldn't produce this effect with the default ruleset and trunk r20866 -- with Barracks and Sun Tzu, my first Warriors were created as merely veteran, not hardened

However, I can see places where the AI behaves as though it is true, for instance dai_choose_defender_versus().

Jacob Nevins <jtn>
Project Administrator
Thu 16 Feb 2012 06:45:06 PM UTC, original submission:

From bug #19448 : In most rulesets Barracks and Sun Tzu togerther cause multiple veteran levels to be gained for newly built units. Their helptexts should be adjusted accordingly.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 01 Apr 2013 10:48:58 PM UTCcazfiDependencies-=>patch #3793 is dependent
    Sat 18 Feb 2012 09:12:38 PM UTCcazfiPlanned Release2.4.0, 2.5.0=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup