patchFreeciv - Patches: patch #3180, -f (load savefile) for client

 
 
Show feedback again

patch #3180: -f (load savefile) for client

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 03 Mar 2012 10:30:07 PM UTC  
 
Category: clientPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.4, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 15 Nov 2014 07:19:22 PM UTC, comment #7:

Brilliant (seen on the 2.5.0-beta2 draft). This asks for a configurable Windows file extension in a later version:

After name.sav.gz or similar (I'm only using a locked PLAIN); if all savegames + scenarios use, e.g., whatever.sav.fsg, Windows users could associate .fsg with Freeciv, and start x.fsg files with a double click.

Disclaimer, that was an example, .fsg is in use as "FreeCol Save Game", and something longer (after the last dot) would also work.

Frank <dunnoob>
Mon 06 Oct 2014 08:51:36 PM UTC, comment #6:

> I compiled this on windows - it works.

Thanks for testing.

> It is messy though when the client cannot spawn a server.

Of course that shouldn't happen. I guess you ran into bug #22448?
That particular failure won't be handled nicely, no (but complete failure to start the server process should be).
I'm not treating this as a blocker.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 06 Oct 2014 08:50:38 PM UTC, SVN revision 26716:

Add --file option to client to load savefile.

See gna patch #3180.

(Browse SVN revision 26716)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 06 Oct 2014 08:45:56 PM UTC, SVN revision 26715:

Add --file option to client to load savefile.

See gna patch #3180.

(Browse SVN revision 26715)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 06 Oct 2014 08:40:21 PM UTC, SVN revision 26714:

Add --file option to client to load savefile.

See gna patch #3180.

(Browse SVN revision 26714)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 05 Oct 2014 04:16:29 PM UTC, comment #2:

I compiled this on windows - it works.
It is messy though when the client cannot spawn a server.

Anonymous
Sun 05 Oct 2014 12:56:11 PM UTC, comment #1:

Finally got annoyed enough to implement this.

Implementation is about as hacky as --autoconnect, and shares many of the restrictions of other spawned-server options like --read (notably, lack of any error reporting), but I think it's a useful enough feature to commit anyway.

I haven't tried even compiling for Windows; it's possible that I've broken that build due to its gratuitously different server-spawning code.

(file #22541, file #22542)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 03 Mar 2012 10:30:07 PM UTC, original submission:

It would be nice if the clients supported the "-f savefile" option to load a savefile directly from the command line. Should be fairly easy to modify the spawn-a-server code to add this?

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22541:  trunk-client-commandline-load.patch added by jtn (7kB - text/x-patch - trunk/S2_5/S2_4 r26689)
file #22542:  S2_5-S2_4-client-commandline-load.patch added by jtn (7kB - text/x-patch - trunk/S2_5/S2_4 r26689)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dunnoob (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 06 Oct 2014 08:51:36 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sun 05 Oct 2014 12:56:11 PM UTCjtnAttached File-=>Added trunk-client-commandline-load.patch, #22541
      Attached File-=>Added S2_5-S2_4-client-commandline-load.patch, #22542
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
      Planned Release=>2.4.4, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup