patchFreeciv - Patches: patch #3249, Effect to control how effective...

 
 
Show feedback again

patch #3249: Effect to control how effective trade routes are

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 12 Apr 2012 11:07:51 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 17 Mar 2014 06:14:13 PM UTC, SVN revision 24692:

Added effect type "Traderoute_Pct" to give bonus to traderoute income for one end.

Requested by David Fernandez

See patch #3249

(Browse SVN revision 24692)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 14 Mar 2014 02:21:25 AM UTC, comment #5:

- Corrected Trade_Revenue_Bonus documentation

(file #20321)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 09 Mar 2014 01:42:37 AM UTC, comment #4:

Yes, it could be nice addition, but at the same time get_city_bonus() is mucher simpler so I would be inclined to go with it first, and to leave diplrel options as future enhancement
Piece by piece is a good approach.

Sveinung Kvilhaugsvik <sveinung>
Project Member
Sun 09 Mar 2014 01:27:13 AM UTC, comment #3:

> Have you considered supporting local DiplRel requirements


Yes, it could be nice addition, but at the same time get_city_bonus() is mucher simpler so I would be inclined to go with it first, and to leave diplrel options as future enhancement (I don't have plans to use them in my rulesets). I can make the diplrel implmentation, of course, if you think we should have it from the beginning.

Attached version of the patch is just updated against svn HEAD.

(file #20290)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 02 Mar 2014 02:29:54 AM UTC, comment #2:

Have you considered supporting local DiplRel requirements with the owner of the city at the other end of the trade route as other_player here? That would allow rules like "the output of a trade route to a player you are at war with is halved unless you run a monarchy".

Sveinung Kvilhaugsvik <sveinung>
Project Member
Sat 01 Mar 2014 11:39:19 PM UTC, comment #1:

Attached patch adds "Traderoute_Pct" effect that applies to one end of the traderoute only.

(file #20223)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 12 Apr 2012 11:07:51 PM UTC, original submission:

I patch #3178 discussion David Fernandez <bardo> suggests adding support for effect to control how much trade trade routes produce.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20321:  TraderoutePct-3.patch added by cazfi (4kB - text/x-diff)
file #20290:  TraderoutePct-2.patch added by cazfi (4kB - text/x-diff)
file #20223:  TraderoutePct.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 17 Mar 2014 06:14:25 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 14 Mar 2014 02:21:25 AM UTCcazfiAttached File-=>Added TraderoutePct-3.patch, #20321
    Sun 09 Mar 2014 01:27:13 AM UTCcazfiAttached File-=>Added TraderoutePct-2.patch, #20290
    Sat 01 Mar 2014 11:39:19 PM UTCcazfiStatusNone=>Ready For Test
      Planned Release=>2.6.0
    Sat 01 Mar 2014 11:39:18 PM UTCcazfiAttached File-=>Added TraderoutePct.patch, #20223
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup