patchFreeciv - Patches: patch #3273, fcdb: Add config file variable to...

 
 
Show feedback again

patch #3273: fcdb: Add config file variable to select backend

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Fri 04 May 2012 10:41:30 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 21 May 2012 10:24:09 PM UTC, comment #6:

>> Any hope of sqlite-backend before 2.4.0-final?


> I'm working on it (slowly). It looks do-able.


Note that I don't think there's anything preventing us (it's not subject to freezes) from changing this between beta and final release (but I wouldn't change it after final 2.4.0 release in S2_4 branch). We have not yet released even first beta, and I assume there to be at least 6 months between first beta and final...

Marko Lindqvist <cazfi>
Project Administrator
Tue 08 May 2012 07:11:14 PM UTC, comment #5:

> Any hope of sqlite-backend before 2.4.0-final?

I'm working on it (slowly). It looks do-able.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 08 May 2012 07:10:40 PM UTC, SVN revision 21256:

Add --Database file directive "backend", to allow server operator to easily
choose among multiple backends supported by database.lua.
(However, current database.lua still only supports "mysql".)

See gna patch #3273.

(Browse SVN revision 21256)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 08 May 2012 07:10:20 PM UTC, SVN revision 21255:

Add --Database file directive "backend", to allow server operator to easily
choose among multiple backends supported by database.lua.
(However, current database.lua still only supports "mysql".)

See gna patch #3273.

(Browse SVN revision 21255)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 08 May 2012 12:31:01 AM UTC, comment #2:

This patch is excellent news. Any hope of sqlite-backend before 2.4.0-final? For our db usage MySQL requirement is completely out-of-proportions. I'd rather see sqlite as default backend.

Marko Lindqvist <cazfi>
Project Administrator
Fri 04 May 2012 10:53:52 PM UTC, comment #1:

(Technically this is a violation of the file format freeze, but I don't think it'll cause trouble in practice. Anyone going to object?)

(file #15669)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 04 May 2012 10:41:30 PM UTC, original submission:

Currently, the only way for a server administrator to change which database backend is used for user authentication (fcdb) would be to hack on data/database.lua -- there's no way of affecting this in the --Database config file, server command-line etc.

This is unwieldy. Since the database script file data/database.lua can't be moved either, it also means we can't supply a database.lua that works out of the box with multiple database backends (the current one only supports MySQL).

I propose adding a new directive to the config file supplied to --Database where server operators put database details, "backend", e.g. backend="mysql" or backend="sqlite". The script data/database.lua would look at that variable and switch its function suite based on it.

Attached patch is the minimal implementation of this (database.lua just checks that the backend specifies is "mysql" and barfs otherwise).

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15669:  trunk-S2_4-fcdb-backend-var.diff added by jtn (4kB - text/x-diff - trunk/S2_4 r21247)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 08 May 2012 07:12:00 PM UTCjtnDependencies-=>patch #3287 is dependent
    Tue 08 May 2012 07:11:14 PM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Fri 04 May 2012 10:53:52 PM UTCjtnAttached File-=>Added trunk-S2_4-fcdb-backend-var.diff, #15669
      StatusIn Progress=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup