patchFreeciv - Patches: patch #3287, fcdb: support SQLite backend...

 
 
Show feedback again

patch #3287: fcdb: support SQLite backend "out of the box"

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 08 May 2012 07:11:27 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 10 Jul 2012 08:49:39 AM UTC, SVN revision 21495:

Add SQLite support to database.lua.
Also bugfixes for MySQL and updated README.fcdb.

See gna patch #3287.

(Browse SVN revision 21495)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 10 Jul 2012 08:47:36 AM UTC, SVN revision 21490:

Add SQLite support to database.lua.
Also bugfixes for MySQL and updated README.fcdb.

See gna patch #3287.

(Browse SVN revision 21490)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 08 Jul 2012 05:20:33 PM UTC, comment #2:

Patches attached, at long last. Apart from the obvious, notable changes:

  • Database/table creation is via a Lua function (invoked at the server prompt: /lua fcdb sqlite_createdb())
  • Don't rely on :numrows() method, as SQLite backend doesn't support it for some reason
  • Remove MySQL-specific SQL syntax
  • Update README.fcdb for all this, including strong encouragement to use SQLite for new installations
  • Non-SQLite stuff:
    • MySQL bug fix: 'port' was not honoured
    • Don't spew potentially-sensitive SQL queries all over the server logs
    • Less chatter at log_normal level
    • Some general updates to README.fcdb

The S2_4 version additionally mentions this in README.packaging, and encourages packagers to build in SQLite support.

(file #16028, file #16029)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 13 May 2012 11:43:20 PM UTC, comment #1:

I have this basically working, with a single database.lua working for both SQLite and MySQL. Still some polishing required.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 08 May 2012 07:11:27 PM UTC, original submission:

Raising a ticket to note that I'm working on making SQLite support work more or less "out of the box" as a release goal for 2.4.0. This should allow servers running authentication without the faff of running a database server, and in particular may allow us to ship a Windows server binary which supports authentication fairly easily.

What it's looking like currently:

  • Run a different init function in database.lua, based on the new "backend" variable (patch #3273)
  • Remove MySQL extensions from the SQL elsewhere in database.lua
  • Some way to create the initial database file
Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16028:  trunk-sqlite.patch added by jtn (18kB - text/x-diff - trunk/S2_4 r21471)
file #16029:  S2_4-sqlite.patch added by jtn (19kB - text/x-diff - trunk/S2_4 r21471)

 

Digest:
   bug dependencies, patch dependencies.

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 10 Jul 2012 08:58:04 AM UTCjtnStatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Sun 08 Jul 2012 05:20:47 PM UTCjtnDependenciesRemoved dependancy to bugs #19729=>-
    Sun 08 Jul 2012 05:20:33 PM UTCjtnAttached File-=>Added trunk-sqlite.patch, #16028
      Attached File-=>Added S2_4-sqlite.patch, #16029
      StatusIn Progress=>Ready For Test
    Sun 13 May 2012 11:39:20 PM UTCjtnDependencies-=>Depends on bugs #19733
    Sat 12 May 2012 08:35:43 PM UTCjtnDependencies-=>Depends on bugs #19729
    Tue 08 May 2012 07:12:00 PM UTCjtnDependencies-=>Depends on patch #3273
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup