patchFreeciv - Patches: patch #3301, xz compressed tarballs

 
 
Show feedback again

patch #3301: xz compressed tarballs

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Wed 16 May 2012 02:20:36 AM UTC  
 
Category: bootstrapPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 18 Sep 2014 11:15:53 PM UTC, comment #14:

- Updated against svn

(file #22278)

Marko Lindqvist <cazfi>
Project Administrator
Tue 29 Jul 2014 11:19:38 PM UTC, comment #13:

(Note target release 3.0)

- Replace tar.bz2 distribution with tar.xz
- Do it for both automake and automake-ng ways
- Bumb minimum automake version to 1.11

(file #21587)

Marko Lindqvist <cazfi>
Project Administrator
Sun 08 Jul 2012 06:47:47 PM UTC, comment #12:

> Any reason not to port the bz2/zip automake changes back to
> S2_3? They'd save a manual step in future 2.3.x releases.


How many more releases you expect from S2_3? Bugfixes flow in quite slowly already. Would we take risks and do work in porting & testing .tar.bz2 and .zip creation on S2_3 to save work in just one or two releases?

> Is automake 1.8 an onerous requirement? It only affects people
> building from svn or regenerating configure etc. Do these
> specific changes affect anyone who doesn't actually run "make
> dist"?


It doesn't matter if user ever actually runs "make dist", it's the generating support for it in Makefiles that set the automake requirement. So anyone running autogen.sh would need at least automake 1.8, older ones would error out for unknown init parameter. Strictly speaking our policy is not to bump minimum requirements within release branch after first release. Anyone who has built earlier version from that branch should be able to benefit from bugfixes, most importantly potential security related ones. At the same time I find it rather unlikely that anybody has ever built freeciv S2_3 with automake older than 1.8, which itself is ancient already.

> Perhaps we're relying on it already?


Maybe, it's quite possible that older versions (or even 1.8) doesn't work. Testing that has never been high enough priority in my TODO to get actually done. Nobody has reported build failures...

> I notice a reference to
> "WANT_AUTOMAKE=1.8" at the top of autogen.sh (labelled as a
> Gentoo kludge).


History of that one should be investigated. It can even be breaking things more than fixing nowadays... In any case it's very old thing, but I'm not sure what automake version it was meant to protect against (what was the default gentoo automake that didn't produce correct results)? Was it upgrade from default automake; "use 1.8 instead of 1.6", or downgrade; "use 1.8 instead of 1.10"?
I do know that the kludge predates changes that autogen.sh is able to check against multiple tool versions instead of just default one.

Marko Lindqvist <cazfi>
Project Administrator
Sat 07 Jul 2012 12:40:47 PM UTC, comment #11:

So, on the general topic of which compression formats to distribute in future (which this is probably the wrong place for, but never mind)...

> We're certainly late by introducing .tar.bz2 now when others
> are already abandoning it.

We've actually been shipping .tar.bz2 since 1.5.3(!), apparently (see here). Since 2.0.0 we've been shipping all of .tar.gz, .tar.bz2, and .zip, the latter two presumably produced by the mandraulic release process.
(I had no idea it was so easy to get automake to do it for you -- as you can probably tell, I don't really understand automake.)

And then there was

>>> there's always .zip as a fallback.
>> We have .zip?
> Yup.

...which resulted in patch #3331, now applied to S2_4/trunk.

So now we have:

  • S2_3 building .tar.gz and mandraulic process to distribute .tar.bz2 and .zip
  • S2_4+ building all three from "make dist" (so users see nothing different)

So, two remaining questions:

  • Back to comment #7: from 2.4, can we drop .tar.gz, and use .zip as the lo-fi fallback?
    • (Excepting the anti-ZIP arguments we've already heard.)
    • My vague recollection of days when gzip/zip were scarce is that systems had both, or neither (only "compress").
    • Sourceforge download stats for 2.3.2:
      • .tar.bz2 (default for Unix browsers): 1300-2000/month (49% Linux, 35% Windows, 10% unknown)
      • .zip (default for no-one): 320-480/month (86% Windows users, rest mostly split evenly between Linux/Mac/unknown)
      • .tar.gz (default for no-one): 110-160/month (60% Linux, 26% Windows, 12% Mac, 3% Unknown)
      • (For comparison, the Windows gtk installer is 7400-15200/month.)
    • For me the bulk of the release time is uploading, so the fewer formats the better. If .tar.gz is genuinely useful then I don't put my personal convenience ahead of that of users, but if it's a waste of time I'd happily drop it.
  • Any reason not to port the bz2/zip automake changes back to S2_3? They'd save a manual step in future 2.3.x releases.
    • Is automake 1.8 an onerous requirement? It only affects people building from svn or regenerating configure etc. Do these specific changes affect anyone who doesn't actually run "make dist"?
      • (As current release manager, I seem to have automake 1.11.1, and am unlikely to regress.)
    • Perhaps we're relying on it already? I notice a reference to "WANT_AUTOMAKE=1.8" at the top of autogen.sh (labelled as a Gentoo kludge).
Jacob Nevins <jtn>
Project Administrator
Fri 15 Jun 2012 08:47:51 PM UTC, comment #10:

>> there's always .zip as a fallback.
> We have .zip? Do we have some extra hops in release
> process to produce one, since I don't see it in automake
> options?

Yup. See manual steps at <http://freeciv.wikia.com/wiki/Release#Upload_source_archives>.

Jacob Nevins <jtn>
Project Administrator
Wed 23 May 2012 09:02:28 PM UTC, comment #9:

> I've been wondering whether we can drop .tar.gz entirely, maybe
> from 2.4 onwards, in favour of .tar.bz2. .tar.gz doesn't get
> many downloads from Sourceforge.


I've seen this discussion for several projects lately. Most often it's decided that .tar.gz shoudl be provided as idiot-proof format, and .tar.xz as modern one, meaning that projects taht earlier provided .tar.gz and .tar.bz2 are dropping .tar.bz2 in favor of .tar.xz and leave .tar.gz as is. We're certainly late by introducing .tar.bz2 now when others are already abandoning it.

> there's always .zip as a fallback.


We have .zip? Do we have some extra hops in release process to produce one, since I don't see it in automake options?

Marko Lindqvist <cazfi>
Project Administrator
Tue 22 May 2012 06:29:48 PM UTC, comment #8:

Sigh, read all emails before replying... I see you're looking at bz2 tarballs in patch #3303.

Jacob Nevins <jtn>
Project Administrator
Tue 22 May 2012 06:27:36 PM UTC, comment #7:

I've been wondering whether we can drop .tar.gz entirely, maybe from 2.4 onwards, in favour of .tar.bz2. .tar.gz doesn't get many downloads from Sourceforge.
I'd've thought that any platform that can make use of modern Freeciv source code can deal with bzip2 by now, and there's always .zip as a fallback.

Jacob Nevins <jtn>
Project Administrator
Mon 21 May 2012 05:53:44 PM UTC, comment #6:

Wait until time is suitable for making automake 1.11 minimum requirement.

Marko Lindqvist <cazfi>
Project Administrator
Mon 21 May 2012 05:52:29 PM UTC, SVN revision 21286:

Reverted xz compressed tarballs (patch #3301) as
it made minimum automake version requirement too high.

See gna patch #3301

(Browse SVN revision 21286)

Marko Lindqvist <cazfi>
Project Administrator
Mon 21 May 2012 05:51:12 PM UTC, SVN revision 21285:

Reverted xz compressed tarballs (patch #3301) as
it made minimum automake version requirement too high.

See gna patch #3301

(Browse SVN revision 21285)

Marko Lindqvist <cazfi>
Project Administrator
Sun 20 May 2012 06:29:41 PM UTC, comment #3:

It occurred me to check what automake version this requires only after committing.
Digging automake ChangeLogs it seems that tar.xz support was added in 1.11. I'll test what older ones do with unknown (to them) options, but if it doesn't work I think we have to revert this. Maybe build bzip2 compressed tarballs for now instead (bzip2 was first mentioned in automake ChangeLog for 1.8)

Marko Lindqvist <cazfi>
Project Administrator
Sun 20 May 2012 06:13:59 PM UTC, SVN revision 21284:

Build xz compressed tarballs in addition to gzipped ones.

See gna patch #3301

(Browse SVN revision 21284)

Marko Lindqvist <cazfi>
Project Administrator
Sun 20 May 2012 06:13:47 PM UTC, SVN revision 21283:

Build xz compressed tarballs in addition to gzipped ones.

See gna patch #3301

(Browse SVN revision 21283)

Marko Lindqvist <cazfi>
Project Administrator
Wed 16 May 2012 02:20:36 AM UTC, original submission:

Build .tar.xz distributions in addition to .tar.gz ones. Built from current trunk latter was 41M and former 24M.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21587:  XzDist-2.patch added by cazfi (2kB - text/x-diff)
file #15746:  XzDist.diff added by cazfi (447B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Sep 2014 11:15:53 PM UTCcazfiAttached File-=>Added 0004-Build-xz-compressed-tarballs.patch, #22278
    Tue 29 Jul 2014 11:19:38 PM UTCcazfiAttached File-=>Added XzDist-2.patch, #21587
      StatusPostponed=>Ready For Test
    Fri 11 Apr 2014 10:45:07 PM UTCcazfiPlanned Release=>3.0.0
    Mon 02 Jul 2012 01:10:03 PM UTCcazfiAssigned tocazfi=>None
    Mon 21 May 2012 05:54:08 PM UTCcazfiPlanned Release2.4.0, 2.5.0=>
    Mon 21 May 2012 05:53:44 PM UTCcazfiStatusNeed Info=>Postponed
    Sun 20 May 2012 06:29:41 PM UTCcazfiStatusDone=>Need Info
      Open/ClosedClosed=>Open
    Sun 20 May 2012 06:14:32 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 16 May 2012 02:20:36 AM UTCcazfiAttached File-=>Added XzDist.diff, #15746
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup