patchFreeciv - Patches: patch #3349, Support for longer "About...

 
 
Show feedback again

patch #3349: Support for longer "About Ruleset" descriptions.

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sat 30 Jun 2012 04:30:54 PM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 14 Aug 2015 04:59:05 PM UTC, SVN revision 29503:

Support ruleset descriptions longer than what would fit in single network packet with rest of the
ruleset control content.

See patch #3349

(Browse SVN revision 29503)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 14 Aug 2015 04:58:31 PM UTC, SVN revision 29502:

Support ruleset descriptions longer than what would fit in single network packet with rest of the
ruleset control content.

See patch #3349

(Browse SVN revision 29502)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 11 Aug 2015 11:21:56 PM UTC, comment #3:

Patches

(file #24849, file #24850)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 12 May 2014 12:26:20 AM UTC, comment #2:

This requires network protocol change, and it makes no sense to provide it via optional capability to frozen S2_5.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 15 Jul 2012 01:37:22 PM UTC, comment #1:

The size of the description string is already MAX_LEN_PACKET (4k -- in practice slightly less since it's sharing the RULESET_CONTROL packet with other stuff.

Perhaps a series of packets containing individual strings that are part of the ruleset description, with each string (paragraph) limited to MAX_LEN_PACKET?

Jacob Nevins <jtn>
Project Administrator
Sat 30 Jun 2012 04:30:54 PM UTC, original submission:

As (once again) mentioned in patch #3024:

> There's also "About Ruleset", but size is limited.


Problem here is in network protocol used to transfer ruleset description to client. We really should rework that to allow good descriptions. Patches welcome.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 14 Aug 2015 04:59:38 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 11 Aug 2015 11:21:56 PM UTCcazfiAttached File-=>Added MultiPartDescription.patch, #24849
      Attached File-=>Added MultiPartDescription-S2_6.patch, #24850
      StatusNone=>Ready For Test
      Planned Release2.6.0=>2.6.0, 3.0.0
    Mon 12 May 2014 12:26:20 AM UTCcazfiPlanned Release2.5.0=>2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup