patchBattle for Wesnoth - Patches: patch #3360, Fix for bug #19862 and more

Show feedback again

patch #3360: Fix for bug #19862 and more

Submitted by:  B. Lipka <lipk>
Submitted on:  Tue Jul 3 14:34:24 2012  
Priority: 5 - NormalStatus: Done
Privacy: PublicAssigned to: B. Lipka <lipk>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Wed Oct 3 17:03:01 2012, SVN revision 55477:

Apply patch #3360 for 1.10

(Browse SVN revision 55477)

B. Lipka <lipk>
Project MemberIn charge of this item.
Mon Oct 1 11:19:26 2012, SVN revision 55454:

Apply patch #3360. Fixes bug #19862 and bug #16220

(Browse SVN revision 55454)

B. Lipka <lipk>
Project MemberIn charge of this item.
Sun Sep 30 17:51:44 2012, comment #5:

It apparently does.

Since no one grabbed this patch in the last two months I think I can safely assign it to myself.

B. Lipka <lipk>
Project MemberIn charge of this item.
Sat Sep 29 01:17:20 2012, comment #4:

Would be worth checking to see if this patch also addresses bug bug #16220

Simon Forsyth <alarantalara>
Project Member
Sat Jul 7 14:40:34 2012, comment #3:

Replaced all occurrences of the foreach macro with BOOST_FOREACH.

(file #16004)

B. Lipka <lipk>
Project MemberIn charge of this item.
Sat Jul 7 09:34:00 2012, comment #2:

Issue solved. Moved some code around in the change control stuff in turn_info::process_network_data() so that it runs even if make_human() was called on the affected team before and added a change_controller() call in the switch statement, under the "Replace with local player" case (I wonder why it wasn't there in the first place).

(file #16000)

B. Lipka <lipk>
Project MemberIn charge of this item.
Fri Jul 6 20:29:59 2012, comment #1:

The patch has an issue, see irc discussion #wesnoth-dev 06.07.2012 20:10 - 20:49

Anonymissimus <anonymissimus>
Project Member
Tue Jul 3 14:34:24 2012, original submission:

This patch fixes #19862 and a bunch of other (possibly not yet spotted) bugs related to transferring control of sides in mp games.
The bugs:

  • droiding your side make you become an observer
  • undroiding your side during the turn of someone else results in your messages appearing in that side's color on your client (a.k.a. bug #19862)
  • when passing control of a side to a player the gui isn't properly updated
  • droiding/undroiding a side during that side's turn would make the actions of that side visible for everyone for that turn

And the respective fixes:

  • modified is_observer() to return true only if there're no human or human_ai sides
  • solved as a side effect of fix 1
  • added the appropriate function calls in turn_info::process_network_data()
  • removed unnecessary update_gui_to_player() call at playmp_controller.cpp:492
B. Lipka <lipk>
Project MemberIn charge of this item.


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #16004:  change_control_fix.diff added by lipk (2kB - text/x-patch)
file #16000:  change_control_fix.diff added by lipk (2kB - text/x-patch)
file #15964:  change_control_fix.diff added by lipk (2kB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by alarantalara (Posted a comment)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by lipk (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Mar 14 07:47:48 2013shadowmasterOpen/ClosedOpen=>Closed
    Mon Oct 1 11:22:06 2012lipkStatusIn Progress=>Done
    Sun Sep 30 17:51:44 2012lipkStatusNone=>In Progress
      Assigned toNone=>lipk
    Sat Jul 7 14:40:34 2012lipkAttached File-=>Added change_control_fix.diff, #16004
    Sat Jul 7 09:34:00 2012lipkAttached File-=>Added change_control_fix.diff, #16000
    Tue Jul 3 14:34:24 2012lipkAttached File-=>Added change_control_fix.diff, #15964
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup