|
Sat 14 Jul 2012 11:23:09 PM UTC, comment #8:
Configure check discussion moved to patch #3417.
|
Sat 14 Jul 2012 10:00:56 PM UTC, comment #7:
I've had gui-qt in my trunk builds for a while. Now this is in, I'm getting:
It seems the method 'setPlaceholderText' was introduced in Qt 4.7. I'm on Ubuntu Linux 10.04, and it seems I have Qt 4.6.2.
My distro is now quite old (it's an LTS, but not the latest LTS), so I don't feel aggrieved not to be able to build the Qt client, but I guess we need some configure checks and advertised minimum versions of things.
|
Sat 14 Jul 2012 08:22:05 PM UTC, SVN revision 21547:
Implemented everything required to move units on map and more
on Qt-client.
Patch by mir3x with stylistic changes and marking some
strings for translation by me.
See gna patch #3367
(Browse SVN revision 21547) |
Thu 12 Jul 2012 01:23:31 AM UTC, comment #5:
- Removed more extra spaces between function names and argument lists
- Corrected some comments
- A couple of more strings marked for translation
(file #16066)
|
Sun 08 Jul 2012 10:47:35 PM UTC, comment #4:
First, I'd like to stress I know very little about Qt.
Having said that, after gtk3 client, I have an idea or two that somebody how knows Qt better could adapt.
1. curved line: with cairo, I've done it through cairo_curve_to - AFAICT, in Qt similar effect would be QPainterPath::cubicTo
2. fog - this problem I've sidestepped by CAIRO_OPERATOR_HSL_COLOR (it was extremely lucky that cairo 1.10 added this); unfortunately, I don't see similar operator among CompositionMode enums, but while http://qt.gitorious.org/qt-labs/graphics-dojo/blobs/master/imagetint/imagetint.cpp does something a bit different, it suggests something similar could be done for HSL (though the question would be: can it be done with acceptable performance ?)
|
Sun 08 Jul 2012 08:55:37 PM UTC, comment #3:
I went through the style. I have not yet checked the patch otherwise. There was quite a bit to fix, even if I took relaxed attitude on some details. Some of these things are badly worded in CodigStyle; I'll try to update it a bit after this experience.
- From freeciv perspective Qt headers are system headers, so they are included before any freeciv headers
- Quite a many places you had forgotten {} around single line if, else, for, while, etc blocks. Even complex "for() if singlecommand; else singlecommand;" was found
- "*" in front of each comment line in multiline comments does not apply to function headers
- There's no space between function name and "(". I think your "_ (" constructs even break gettext string collection mechanism, so it's a real bug
The only functional change I did was addition of translating of most of the new strings - for some that need code restructuring to work properly I just added FIXME comment.
(file #16032)
|
Sat 07 Jul 2012 03:12:27 PM UTC, comment #2:
Previous bug removed ( added add_idle_callback which resolved infinite loop )
Known bug - doesnt work with isometric ( amplio2 ) but under gdb runs ok somehow ...
Added first mouse handling ( move map via right click and select units via left click )
Added some menus to make basic stuff like roads ...
Added information bar about gov, turn, time + icons
( changed from left to small down, minimap could be floatable then and unit info )
Fixed Coding style mostly I think
(file #16005)
|
Wed 04 Jul 2012 10:41:29 PM UTC, comment #1:
Thank you. Seems like big step forward for Qt-client.
- Please read doc/CodingStyle. Though it's not yet updated to reflect the fact that Qt-client is C++, and not C, most of it still valid ( "if (" and not "if(", block required even for single command after if... )
- Compiling with --enable-debug -> -Werror:
../../../../src/client/gui-qt/mapview.cpp: In function 'void pixmap_put_overlay_tile(int, int, sprite*)':
../../../../src/client/gui-qt/mapview.cpp:224:6: error: no previous declaration for 'void pixmap_put_overlay_tile(int, int, sprite*)' [-Werror=missing-declarations]
../../../../src/client/gui-qt/optiondlg.cpp:38:35: error: 'option_dialogs' defined but not used [-Werror=unused-variable]
../../../../src/client/gui-qt/optiondlg.cpp:99:13: error: 'void option_dialog_option_apply(option*)' defined but not used [-Werror=unused-function]
../../../../src/client/gui-qt/pages.cpp: In function 'void create_conn_menu(player, connection)':
../../../../src/client/gui-qt/pages.cpp:336:6: error: no previous declaration for 'void create_conn_menu(player, connection)' [-Werror=missing-declarations]
../../../../src/client/gui-qt/pages.cpp: In function 'void server_scan_error(server_scan, const char)':
../../../../src/client/gui-qt/pages.cpp:598:6: error: no previous declaration for 'void server_scan_error(server_scan, const char)' [-Werror=missing-declarations]
|
Wed 04 Jul 2012 10:03:34 PM UTC, original submission:
Added primary widgets
Connect to game possible via network page or ./fcgui -a
( start or load not working but widgets completed )
Visible map and moving units via numpad and arrows.
some bug: after connect if any city is not visible and after resize would be visible, client will lockup in endless loop
(pft_advance_path
city_map_radius_sq_get
genhash_replace_full
secfile_destroy
update_map_canvas
qtg_canvas_put_rectangle
city_map_radius_sq_set
client_map_is_known_and_seen
fc_isalnum
fill_sprite_array )
if city is already visible or after unit movement is visible then it works ok. It happens only at first resize.
|
Related Recipes:
Freeciv - Patches: patch #3367, A bit playable qt-client