patchFreeciv - Patches: patch #3424, City dialog created for Qt Version

Show feedback again

patch #3424: City dialog created for Qt Version

Submitted by:  mir3x <mir3x>
Submitted on:  Sun Jul 15 21:29:49 2012  
Category: client-qtPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


(Jump to the original submission Jump to the original submission)

Fri Jul 20 22:23:27 2012, SVN revision 21589:

Added gui-qt/citydlg.c file missing from earlier patch #3424 commit.

Spotted by Jacob Nevins

(Browse SVN revision 21589)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Jul 20 22:09:29 2012, comment #5:

I think citydlg.h was missed from the commit to svn (r21586), although it's in the attached patches.

With citydlg.h from file #16129, it builds and runs for me.

Jacob Nevins <jtn>
Project Administrator
Fri Jul 20 21:50:22 2012, SVN revision 21586:

Added city dialog and some misc stuff to Qt-client

Patch by mir3x

See gna patch #3424

(Browse SVN revision 21586)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jul 18 07:41:05 2012, comment #3:

Generally each patch should contain just one change, and no unrelated things. No need to split this patch, but keep it in mind when writing future patches.

Changes in attached version:

- Minor style corrections
- Replaced includes in citydlg.h with class forward declarations as only pointers are needed
- Corrected a couple of errors in translatable strings
- Use population_to_text() instead of just adding string "000"

(file #16129)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Jul 16 01:00:53 2012, comment #2:

You might want to take a look at

Sun Jul 15 23:00:08 2012, comment #1:

I just noticed that translated showed strings are bad, but addding
in main() will fix it - there is a lot of strings to update cause small/big letter mismatch and many of them are not translated due to that )

mir3x <mir3x>
Project Member
Sun Jul 15 21:29:49 2012, original submission:

- Created Overview tab in city dialog
( lacks selling improvements, needs to clip black borders on city view, cause there is a lot of black borders in amplio, also to change production chooser from combobox to listview probably with delagated progress bar )
- Some fix with map redraws
- removed tr() functions, ( original qt function used to translation )
- removed qDebug
- fixed seg fault when using amplio
- removed placeholders

mir3x <mir3x>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #16129:  QtCityDlg.patch.bz2 added by cazfi (11kB - application/x-bzip)
file #16111:  qt_city_dialog.patch added by mir3x (52kB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by mir3x (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Jul 20 21:50:52 2012cazfiStatusReady For Test=>Done
    Wed Jul 18 07:41:05 2012cazfiAttached File-=>Added QtCityDlg.patch.bz2, #16129
      StatusNone=>Ready For Test
      Assigned toNone=>cazfi
      Planned Release=>2.5.0
    Sun Jul 15 21:29:50 2012mir3xAttached File-=>Added qt_city_dialog.patch, #16111
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup