patchFreeciv - Patches: patch #3433, Remove Gtk2-specific code from...

 
 
Show feedback again

patch #3433: Remove Gtk2-specific code from Gtk3 client

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Thu 19 Jul 2012 09:11:46 AM UTC  
 
Category: client-gtk-3.0Priority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 25 Jul 2012 08:08:19 PM UTC, SVN revision 21621:

Removed conditionally compiled gtk2 specific code from gtk3-client.

See gna patch #3433

(Browse SVN revision 21621)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 25 Jul 2012 08:08:02 PM UTC, SVN revision 21620:

Removed conditionally compiled gtk2 specific code from gtk3-client.

See gna patch #3433

(Browse SVN revision 21620)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 23 Jul 2012 09:03:32 PM UTC, comment #5:

- Removed resources.h include from gui_main.c

(file #16176, file #16177)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 20 Jul 2012 11:58:38 PM UTC, comment #4:

- S2_4 version

(file #16144)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 20 Jul 2012 10:50:04 PM UTC, comment #3:

New version for TRUNK (S2_4 version coming later)

- Remove freeciv.rc-2.0 stuff, including resources

In addition to applying this patch, files rc2c and resources.[ch] should be completely removed.

(file #16143)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 20 Jul 2012 10:23:09 PM UTC, comment #2:

If this is a prerequisite for further patches to the Gtk3 client, I think it'll need to go to 2.4.0 as well.

How about removing the freeciv.rc-2.0 related stuff from the Gtk3 Makefile, and fallback_resources[] while removing Gtk2 things? As noted in bug #19955, it's not used.

Jacob Nevins <jtn>
Project Administrator
Fri 20 Jul 2012 10:17:11 PM UTC, comment #1:

Patch

(file #16141)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 19 Jul 2012 09:11:46 AM UTC, original submission:

In the early days of gui-gtk-3.0, it was actually a Gtk2 program, but as of patch #3041 it's definitely Gtk3-only.

The desire has been expressed several times to remove the Gtk2-specific code (GTK_CHECK_VERSION etc) from the Gtk3 client (bug #19633, bug #19900, bug #19955, ...), for instance to allow use of Gtk3-only features, so let's at least have a ticket for it.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16176:  Gtk3Gtk3Only-3.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #16177:  Gtk3Gtk3Only-S2_4-3.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #16144:  Gtk3Gtk3Only-S2_4-2.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #16143:  Gtk3Gtk3Only-2.patch.bz2 added by cazfi (7kB - application/x-bzip)
file #16141:  Gtk3Gtk3Only.patch.bz2 added by cazfi (6kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by galtgendo
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Jul 2012 08:09:30 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 23 Jul 2012 09:03:32 PM UTCcazfiAttached File-=>Added Gtk3Gtk3Only-3.patch.bz2, #16176
      Attached File-=>Added Gtk3Gtk3Only-S2_4-3.patch.bz2, #16177
    Mon 23 Jul 2012 09:32:32 AM UTCgaltgendoCarbon-Copy-=>Added galtgendo
    Fri 20 Jul 2012 11:58:38 PM UTCcazfiAttached File-=>Added Gtk3Gtk3Only-S2_4-2.patch.bz2, #16144
    Fri 20 Jul 2012 10:50:04 PM UTCcazfiAttached File-=>Added Gtk3Gtk3Only-2.patch.bz2, #16143
      Planned Release2.5.0=>2.4.0, 2.5.0
    Fri 20 Jul 2012 10:17:11 PM UTCcazfiAttached File-=>Added Gtk3Gtk3Only.patch.bz2, #16141
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup