patchFreeciv - Patches: patch #3464, Make it possible to use...

Show feedback again

patch #3464: Make it possible to use database.lua from srcdir in --enable-debug builds

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 30 Jul 2012 03:52:48 PM UTC  
Category: generalPriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat 01 Sep 2012 07:05:41 AM UTC, comment #2:

As patch name says, it searches database.lua from builddir, not srcdir. With srcdir != builddir that requires manual copying (or, as I had done in testing, creating link)

Marko Lindqvist <cazfi>
Project Administrator
Mon 27 Aug 2012 06:36:12 PM UTC, comment #1:


(file #16444)

Marko Lindqvist <cazfi>
Project Administrator
Mon 30 Jul 2012 03:52:48 PM UTC, original submission:

If there's no outcry against, I'll look in to implenting $subject.

Though srcdir/data is one of freeciv datadirs, it's much safer to look explicitly from it than the old, now obsoleted, method of looking from any datadir. Looking directly from srcdir/data means that database.lua installed (possibly by malicious intent) to higher priority datadir will not be used.
freeciv-modpack will not install anything to srcir/data, but to user's homedir. There is the possibility that someone manually unzips modpack with modified database.lua to srcdir/data. Anyway, we already accept that --enable-debug produces builds making freeciv developer's life easier at the cost of less security (those running --enable-debug builds are expected to know what they do)

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #16444:  BuilddirAuth.patch added by cazfi (4kB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 29 Oct 2013 06:53:12 PM UTCcazfiPlanned Release2.5.0=>
    Mon 17 Dec 2012 12:28:07 AM UTCcazfiStatusReady For Test=>In Progress
    Mon 27 Aug 2012 06:36:12 PM UTCcazfiAttached File-=>Added BuilddirAuth.patch, #16444
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup