patchFreeciv - Patches: patch #3464, Make it possible to use...

Show feedback again

patch #3464: Make it possible to use database.lua from srcdir in --enable-debug builds

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon Jul 30 15:52:48 2012  
Category: generalPriority: 5 - Normal
Status: PostponedPrivacy: Public
Assigned to: NoneOpen/Closed: Open
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sun Feb 21 19:08:13 2016, comment #4:

I have no need for this myself at the moment, and don't want to weaken security juts in case someone later finds use for the feature.

Marko Lindqvist <cazfi>
Project Administrator
Mon Feb 8 03:12:56 2016, comment #3:

- Updated against svn & patch #6929
- Use AC_CONFIG_LINKS() to create database.lua as symbolic link in builddir, if it's not the same as srcdir

(file #26646)

Marko Lindqvist <cazfi>
Project Administrator
Sat Sep 1 07:05:41 2012, comment #2:

As patch name says, it searches database.lua from builddir, not srcdir. With srcdir != builddir that requires manual copying (or, as I had done in testing, creating link)

Marko Lindqvist <cazfi>
Project Administrator
Mon Aug 27 18:36:12 2012, comment #1:


(file #16444)

Marko Lindqvist <cazfi>
Project Administrator
Mon Jul 30 15:52:48 2012, original submission:

If there's no outcry against, I'll look in to implenting $subject.

Though srcdir/data is one of freeciv datadirs, it's much safer to look explicitly from it than the old, now obsoleted, method of looking from any datadir. Looking directly from srcdir/data means that database.lua installed (possibly by malicious intent) to higher priority datadir will not be used.
freeciv-modpack will not install anything to srcir/data, but to user's homedir. There is the possibility that someone manually unzips modpack with modified database.lua to srcdir/data. Anyway, we already accept that --enable-debug produces builds making freeciv developer's life easier at the cost of less security (those running --enable-debug builds are expected to know what they do)

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #26646:  BuilddirAuth-2.patch added by cazfi (4kB - text/plain-diff)
file #16444:  BuilddirAuth.patch added by cazfi (4kB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Feb 21 19:08:13 2016cazfiStatusDone=>Postponed
      Planned Release2.6.0, 3.0.0=>
    Mon Feb 8 03:12:56 2016cazfiAttached File-=>Added BuilddirAuth-2.patch, #26646
      StatusIn Progress=>Done
      Planned Release=>2.6.0, 3.0.0
    Tue Oct 29 18:53:12 2013cazfiPlanned Release2.5.0=>
    Mon Dec 17 00:28:07 2012cazfiStatusReady For Test=>In Progress
    Mon Aug 27 18:36:12 2012cazfiAttached File-=>Added BuilddirAuth.patch, #16444
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup