patchFreeciv - Patches: patch #3468, Metaticket: Clang clean build

 
 
Show feedback again

patch #3468: Metaticket: Clang clean build

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue Jul 31 21:59:27 2012  
 
Category: bootstrapPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0-beta2, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat Nov 22 19:43:45 2014, comment #8:

Copying from bug #22915, since I keep looking for it here:

>> This is last patch to make code clang-3.4 clean in S2_5 and
>> TRUNK.
> [...] now code is both clang-3.4 and clang-3.5 clean.

Jacob Nevins <jtn>
Project Administrator
Sat Jul 19 18:08:10 2014, comment #7:

> The main upstream problem I were thinking about is that
> MagickWand-config gives bad CPPFLAG for us.


This is now fixed in a bit hackish filtering of the flags. In general existing patches are enough to fix all the clang warnings I'm getting (x86_64 Debian Testing, clang-3.3-16) in S2_5 and TRUNK, so I would expect any future release (including 2.5.0-beta2) from S2_5 or later branches to be clang-clean (with some clang version(s), obviously we cannot support new versions immediately and we will drop support for the very old versions. Just like with gcc)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Jan 16 19:57:52 2014, comment #6:

> We can aim for Clang-clean with all options like --enable
> sys-lua enabled to remove as much upstream trouble as possible?


The main upstream problem I were thinking about is that MagickWand-config gives bad CPPFLAG for us.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jan 11 10:49:17 2014, comment #5:

> Some things seem like derived from upstreams in a way that we
> really depend on upstream to fix them.

We can aim for Clang-clean with all options like --enable-sys-lua enabled to remove as much upstream trouble as possible?

Jacob Nevins <jtn>
Project Administrator
Sat Jan 11 07:57:15 2014, comment #4:

patch #4421 is now about silencing the evil -Wtautological-compare, and after that the remaining errors seem rather relevant. Not that I'm sure we can reach clang-clean build in freeciv itself ( -> we cannot decide the schedule). Some things seem like derived from upstreams in a way that we really depend on upstream to fix them.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu Feb 21 14:51:55 2013, comment #3:

Looking at the clang warnings lists I'm inclined to say that clang clean build should not be goal for us, or at least many warning types should be silenced with -Wno- -options instead of reworking the code to avoid the warning. For instance the "tautological compare" warnings because macro expansion often leads to value being compared to itself seem more like something that compiler should use for optimization, not to nag developers about. To work around them would make code much more complicated and likely introduce a lot of real bugs while fixing none.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Jan 30 10:39:53 2013, comment #2:

> I don't think anybody wants to fight warnings from lua-5.1 and
> friends when we hopefully get lua-5.2 to use before 2.5 (another
> release goal?)


As lua gets build first, it's rather hard to work on this before lua is updated. There seems to be no progress on that front. I think it's unrealistic to expect us to take project of clang warnings fixing between lua update and 2.5.0 release.
So, let's update lua for 2.5 and target clang warning fixing to 2.6.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Jul 31 22:13:58 2012, comment #1:

I don't think anybody wants to fight warnings from lua-5.1 and friends when we hopefully get lua-5.2 to use before 2.5 (another release goal?)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue Jul 31 21:59:27 2012, original submission:

Clang warnings came too late to be considered for systematic fixing in S2_3. However, getting all of them resolved should be release goal at some point. At least for 2.5, 2.4 would be nice, but I don't want to add new goals this late if they end postponing the release - I think that we should commit any fixes to S2_4 too (those that turn out to be real bugs naturally even to S2_3) but accept the fact if they are not all fixed by the time 2.4.0 is otherwise ready.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies, patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 19 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Sep 18 02:07:13 2014cazfiStatusNone=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
      Planned Release2.6.0=>2.5.0-beta2, 2.6.0
    Sat Jul 19 18:01:20 2014cazfiDependencies-=>Depends on patch #4963
    Tue Jul 15 08:42:52 2014cazfiDependencies-=>Depends on bugs #22321
    Tue Jul 15 08:42:16 2014cazfiDependencies-=>Depends on bugs #22349
    Tue Jul 15 08:41:47 2014cazfiDependencies-=>Depends on patch #4957
    Sat Jun 7 22:17:50 2014cazfiDependencies-=>Depends on patch #4785
    Thu Jan 16 20:05:37 2014cazfiDependencies-=>Depends on bugs #21493
    Thu Jan 16 19:58:13 2014cazfiDependencies-=>Depends on bugs #21492
    Sat Jan 11 07:46:24 2014cazfiDependencies-=>Depends on patch #4421
    Tue Dec 31 12:25:04 2013jtnDependencies-=>Depends on patch #4373
    Tue Dec 31 12:24:37 2013jtnDependencies-=>Depends on bugs #20776
    Wed Jan 30 10:39:53 2013cazfiPlanned Release2.5.0=>2.6.0
    Tue Jul 31 22:20:14 2012jtnDependencies-=>Depends on bugs #18872
    Tue Jul 31 22:19:59 2012jtnDependencies-=>Depends on bugs #18979
    Tue Jul 31 22:19:30 2012jtnDependencies-=>Depends on bugs #19307
    Tue Jul 31 22:13:58 2012cazfiPlanned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup