patchFreeciv - Patches: patch #3478, Salt water filling freshwater lake...

 
 
Show feedback again

patch #3478: Salt water filling freshwater lake when connected

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 03 Aug 2012 01:51:30 AM UTC  
 
Category: generalPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 08 Aug 2012 09:44:21 PM UTC, comment #6:

Unfortunately this means that any land-to-water transformation on the edge of a lake turns the whole lake into ocean, due to transform_result="Ocean". I've raised bug #20038.

Jacob Nevins <jtn>
Project Administrator
Wed 08 Aug 2012 05:58:14 PM UTC, SVN revision 21762:

When ocean is connected to frshwater lake by transforming land between,
ocean fills entire lake.

See gna patch #3478

(Browse SVN revision 21762)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 03 Aug 2012 11:48:20 PM UTC, comment #4:

> My desire started as annoyance at the sharp boundary drawn
> between ocean and lake when transforming terrain


Lack of handling of these boundaries (I guess it can get really ugly in some corner(pun intended)cases where some combination of lake, ocean, deep ocean, and land is in play) in our tilesets motivated me to write this patch. I consider it fix, or at least workaround, to a bug. Potential strategic feature for custom rulesets is just a bonus (well, I already noticed one strategic consequence when testing: player who saw only the other end of the lake could deduct that swamp in the other end was transformed to ocean)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 03 Aug 2012 11:38:13 PM UTC, comment #3:

Aha, I'm glad I'm not the only one who wanted this!

My desire started as annoyance at the sharp boundary drawn between ocean and lake when transforming terrain, but I realised it could be strategic too, in rulesets where fresh water has strategic value.

(I think I posted something to the forum about it.)

Jacob Nevins <jtn>
Project Administrator
Fri 03 Aug 2012 03:10:16 PM UTC, comment #2:

Ah, sorry - should have read the patch first.
You meant this patch should implement this effect.

Rafał Mużyło <galtgendo>
Fri 03 Aug 2012 03:08:03 PM UTC, comment #1:

With tongue in cheek, I'd say that's what would happen in the real world, barring significant height difference.

Rafał Mużyło <galtgendo>
Fri 03 Aug 2012 01:51:30 AM UTC, original submission:

When land tile between ocean and lake gets transformed to ocean, ocean fills lake.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16287:  SaltwaterFill.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Aug 2012 05:58:28 PM UTCcazfiStatusReady For Test=>Done
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 03 Aug 2012 01:51:30 AM UTCcazfiAttached File-=>Added SaltwaterFill.patch, #16287
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup